8306575: Clean up and open source four Dialog related tests #13592

azuev-java · 2023-04-21T21:11:46Z

Cleaned up and stabilized four Dialog-related tests.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8306575: Clean up and open source four Dialog related tests

Reviewers

Phil Race (@prrace - Reviewer) ⚠️ Review applies to 233bc71b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13592/head:pull/13592
$ git checkout pull/13592

Update a local copy of the PR:
$ git checkout pull/13592
$ git pull https://git.openjdk.org/jdk.git pull/13592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13592

View PR using the GUI difftool:
$ git pr show -t 13592

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13592.diff

Webrev

Link to Webrev Comment

Cleaned up and stabilized four Dialog-related tests.

bridgekeeper · 2023-04-21T21:13:27Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-21T21:16:24Z

@azuev-java The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-21T21:20:55Z

Webrevs

01: Full - Incremental (de12275d)
00: Full (233bc71b)

lawrence-andrew · 2023-04-21T21:23:57Z

test/jdk/java/awt/Dialog/DialogLocationTest.java

+    public class CL extends ComponentAdapter {
+        int lastX, lastY;
+        String message = "Failed in componentMoved() expect:[%d,%d]"
+                + " reported: [%d,%d] diff [%d,%d]";


Can you leave a blank line to separate the method .

lawrence-andrew · 2023-04-21T21:27:03Z

test/jdk/java/awt/Dialog/ModalDialogOnNonEdt.java

+import java.util.List;
+
+public class ModalDialogOnNonEdt {
+    public void start () {


Can you leave a blank line here

openjdk · 2023-04-21T22:34:54Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306575: Clean up and open source four Dialog related tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

9ed456f: 8306634: Open source AWT Event related tests
b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure
cb158ff: 8296153: Bump minimum boot jdk to JDK 20
117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13
723037a: 8298048: Combine CDS archive heap into a single block
d518dbf: 8306440: Rename PSS:_num_optional_regions to _max_num_optional_regions
9cd5741: 8306436: Rename PSS*:_n_workers to PSS*:_num_workers
6e77e14: 8306456: Don't leak _worklist's memory in PhaseLive::compute
be6031b: 8303703: Add support of execution tests using virtual thread factory jtreg plugin
5a00617: 8306543: GHA: MSVC installation is failing
... and 62 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2023-04-22T00:13:30Z

/integrate

openjdk · 2023-04-22T00:15:05Z

Going to push as commit 8d696ae.
Since your change was applied there have been 72 commits pushed to the master branch:

9ed456f: 8306634: Open source AWT Event related tests
b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure
cb158ff: 8296153: Bump minimum boot jdk to JDK 20
117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13
723037a: 8298048: Combine CDS archive heap into a single block
d518dbf: 8306440: Rename PSS:_num_optional_regions to _max_num_optional_regions
9cd5741: 8306436: Rename PSS*:_n_workers to PSS*:_num_workers
6e77e14: 8306456: Don't leak _worklist's memory in PhaseLive::compute
be6031b: 8303703: Add support of execution tests using virtual thread factory jtreg plugin
5a00617: 8306543: GHA: MSVC installation is failing
... and 62 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-22T00:15:25Z

@azuev-java Pushed as commit 8d696ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mrserb · 2023-04-24T18:41:27Z

test/jdk/java/awt/Dialog/DialogLocationTest.java

+            });
+            test.start();
+        } finally {
+            EventQueue.invokeLater(() -> {


invokeLater may not be executed before the test stops by the jtreg, EDT could be killed at that point. It is better to use invokeAndWait or somehow make sure it will ends.

invokeLater may not be executed before the test stops by the jtreg, EDT could be killed at that point. It is better to use invokeAndWait or somehow make sure it will ends.

Totally agree.

8306575: Clean up and open source four Dialog related tests

233bc71

Cleaned up and stabilized four Dialog-related tests.

openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Apr 21, 2023

lawrence-andrew reviewed Apr 21, 2023

View reviewed changes

prrace approved these changes Apr 21, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023

Added couple of empty lines to make code nore readable.

de12275

openjdk bot added the integrated Pull request has been integrated label Apr 22, 2023

openjdk bot closed this Apr 22, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2023

mrserb reviewed Apr 24, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8306575: Clean up and open source four Dialog related tests #13592

8306575: Clean up and open source four Dialog related tests #13592

azuev-java commented Apr 21, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 21, 2023

openjdk bot commented Apr 21, 2023

mlbridge bot commented Apr 21, 2023 •

edited

Loading

lawrence-andrew Apr 21, 2023

azuev-java Apr 22, 2023

lawrence-andrew Apr 21, 2023

azuev-java Apr 22, 2023

openjdk bot commented Apr 21, 2023 •

edited

Loading

azuev-java commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

mrserb Apr 24, 2023

aivanov-jdk Apr 24, 2023

8306575: Clean up and open source four Dialog related tests #13592

8306575: Clean up and open source four Dialog related tests #13592

Conversation

azuev-java commented Apr 21, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 21, 2023

openjdk bot commented Apr 21, 2023

mlbridge bot commented Apr 21, 2023 • edited Loading

Webrevs

lawrence-andrew Apr 21, 2023

Choose a reason for hiding this comment

azuev-java Apr 22, 2023

Choose a reason for hiding this comment

lawrence-andrew Apr 21, 2023

Choose a reason for hiding this comment

azuev-java Apr 22, 2023

Choose a reason for hiding this comment

openjdk bot commented Apr 21, 2023 • edited Loading

azuev-java commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

mrserb Apr 24, 2023

Choose a reason for hiding this comment

aivanov-jdk Apr 24, 2023

Choose a reason for hiding this comment

azuev-java commented Apr 21, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 21, 2023 •

edited

Loading

openjdk bot commented Apr 21, 2023 •

edited

Loading