-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again #13593
Conversation
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
/issue JDK-8301377 |
/label add hotspot-runtime |
@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
@dcubed-ojdk |
@dcubed-ojdk |
/issue JDK-8305502 |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
I forgot to include testing info:
The jdk-21+19 stress run will complete late on Sunday, 2023.04.23. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@TobiHartmann - Thanks for the review! My jdk-21+19 stress testing round had no issues with these fixes. /integrate |
Going to push as commit 4b23bef.
Your commit was automatically rebased without conflicts. |
@dcubed-ojdk Pushed as commit 4b23bef. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial fixes to increase timeouts for tests that timeout under heavy stress:
JDK-8301377 adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
JDK-8305502 adjust timeouts in three more M&M tests
JDK-8302607 increase timeout for ContinuousCallSiteTargetChange.java
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13593/head:pull/13593
$ git checkout pull/13593
Update a local copy of the PR:
$ git checkout pull/13593
$ git pull https://git.openjdk.org/jdk.git pull/13593/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13593
View PR using the GUI difftool:
$ git pr show -t 13593
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13593.diff
Webrev
Link to Webrev Comment