Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again #13593

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 21, 2023

Trivial fixes to increase timeouts for tests that timeout under heavy stress:
JDK-8301377 adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
JDK-8305502 adjust timeouts in three more M&M tests
JDK-8302607 increase timeout for ContinuousCallSiteTargetChange.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • JDK-8302607: increase timeout for ContinuousCallSiteTargetChange.java
  • JDK-8305502: adjust timeouts in three more M&M tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13593/head:pull/13593
$ git checkout pull/13593

Update a local copy of the PR:
$ git checkout pull/13593
$ git pull https://git.openjdk.org/jdk.git pull/13593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13593

View PR using the GUI difftool:
$ git pr show -t 13593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13593.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8301377
/issue JDK-8302607
/issue JDK-8302607

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability
/label add hotspot-compiler

@openjdk openjdk bot changed the title Jdk 8301377 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8302607: increase timeout for ContinuousCallSiteTargetChange.java.

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
Updating description of additional solved issue: 8302607: increase timeout for ContinuousCallSiteTargetChange.java.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8305502

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8305502: adjust timeouts in three more M&M tests.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 21, 2023 21:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
8302607: increase timeout for ContinuousCallSiteTargetChange.java
8305502: adjust timeouts in three more M&M tests

Reviewed-by: naoto, lmesnik, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 4900517: 8306636: Disable compiler/c2/Test6905845.java with -XX:TieredStopAtLevel=3
  • 0f51e63: 8305590: Remove nothrow exception specifications from operator new
  • 8d696ae: 8306575: Clean up and open source four Dialog related tests
  • 9ed456f: 8306634: Open source AWT Event related tests
  • b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023
@dcubed-ojdk
Copy link
Member Author

I forgot to include testing info:

  • 8301377 has been tested in jdk-20+34 and jdk-21+{9,1[013-9]} stress testing.
  • 8302607 has been reworked into increasing the timeout and has been tested in jdk-21+1[89] stress testing.
  • 8305502 has been tested in jdk-21+1[7-9] stress testing.

The jdk-21+19 stress run will complete late on Sunday, 2023.04.23.

@dcubed-ojdk
Copy link
Member Author

@naotoj and @lmesnik - Thanks for the reviews!
This PR will likely integrate on Monday (2023.04.24).

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dcubed-ojdk
Copy link
Member Author

@TobiHartmann - Thanks for the review!

My jdk-21+19 stress testing round had no issues with these fixes.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

Going to push as commit 4b23bef.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2023
@openjdk openjdk bot closed this Apr 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@dcubed-ojdk Pushed as commit 4b23bef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8301377 branch April 24, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants