Skip to content

8306566: Open source several clipboard AWT tests#13595

Closed
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_clipboard_8306566
Closed

8306566: Open source several clipboard AWT tests#13595
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_clipboard_8306566

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Apr 21, 2023

Open sourcing few AWT clipboard tests.

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13595/head:pull/13595
$ git checkout pull/13595

Update a local copy of the PR:
$ git checkout pull/13595
$ git pull https://git.openjdk.org/jdk.git pull/13595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13595

View PR using the GUI difftool:
$ git pr show -t 13595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13595.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 21, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306566: Open source several clipboard AWT tests

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure
  • cb158ff: 8296153: Bump minimum boot jdk to JDK 20
  • 117c5b1: 8279216: Investigate implementation of premultiplied alpha in the Little-CMS 2.13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

Going to push as commit 136dad7.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 30fa50d: 8305062: Refactor CardTable::resize_covered_region
  • 4a9f8ef: 8057586: Explicit GC ignored if GCLocker is active
  • ce493dd: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one
  • f7d45b8: 8306076: Open source AWT misc tests
  • 4900517: 8306636: Disable compiler/c2/Test6905845.java with -XX:TieredStopAtLevel=3
  • 0f51e63: 8305590: Remove nothrow exception specifications from operator new
  • 8d696ae: 8306575: Clean up and open source four Dialog related tests
  • 9ed456f: 8306634: Open source AWT Event related tests
  • b2240bf: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure
  • cb158ff: 8296153: Bump minimum boot jdk to JDK 20
  • ... and 1 more: https://git.openjdk.org/jdk/compare/723037a79d2a43b9a1a247d8f81a47907faadab1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2023
@openjdk openjdk bot closed this Apr 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@azvegint Pushed as commit 136dad7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants