8306698: Add overloads to MethodTypeDesc::of

[liach]

Please review this patch adding two new convenience methods that allows easier access to MethodTypeDesc instances and its associated CSR as well. This is a necessity to allow #13186 to reduce array copies in a few scenarios; the implementation of the two methods will be updated there.

Javadoc: https://cr.openjdk.org/~liach/8306698/1/java.base/java/lang/constant/MethodTypeDesc.html

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8306699 to be approved
• Commit message must refer to an issue

Issues

• JDK-8306698: Add overloads to MethodTypeDesc::of
• JDK-8306699: Add overloads to MethodTypeDesc::of (CSR)

Reviewers

• @ExE-Boss (no known openjdk.org user name / role)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13599/head:pull/13599
$ git checkout pull/13599

Update a local copy of the PR:
$ git checkout pull/13599
$ git pull https://git.openjdk.org/jdk.git pull/13599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13599

View PR using the GUI difftool:
$ git pr show -t 13599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13599.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dc2a5a5d)
• 00: Full (6463da2b)

[liach]

Please review this patch, adding two factory methods for MethodTypeDesc for convenience. Thank you!

[liach]

Can any developer for the constant API area take a look at this patch? This API enables sharing of immutable list for method type symbols.

[liach]

@mlchung Since you appear to be back, can you review this patch that allows future immutable-list parameter type sharing and benefit the Classfile API for JDK 21? I would be grateful if you can review a few other java.lang.invoke improvements I submitted as well.

[mlchung]

yes, I'm back from vacation.

This change looks fine. Can you update the copyright header to 2023?

[mlchung]

What is the plan for https://git.openjdk.org/jdk/pull/13186? It seems that keeping argTypes in an array is okay. In any case, we can do the discussion in PR 13186 after this one is integrated.

[liach]

I plan to keep it. Migration to an immutable list to optimize parameterList while it doesn't affect the performance of other accessors. Meanwhile, the list passed by the user code to the factory can be shared safely if it's immutable, while we shouldn't trust the vararg array to the factory.

[liach]

yes, I'm back from vacation.

This change looks fine. Can you update the copyright header to 2023?

The copyright year was already updated to 2023 when covariant override for resolveConstantDesc was added.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306698: Add overloads to MethodTypeDesc::of

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 486 new commits pushed to the master branch:

• 6b27dad: 8301154: SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries
• ed0e956: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
• bddf483: 8303942: os::write should write completely
• ab241b3: 8306706: Support out-of-line code generation for MachNodes
• 710453c: 8308016: Use snippets in java.io package
• e9320f3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
• 97d3b27: 8307523: [vectorapi] Optimize MaskFromLongBenchmark.java
• bb0ff48: 8305091: Change ChaCha20 cipher init behavior to match AES-GCM
• c0c4d77: 8308544: Fix compilation regression from JDK-8306983 on musl libc
• 9e196b3: 8308565: HttpClient: Sanitize logging while stopping
• ... and 476 more: https://git.openjdk.org/jdk/compare/8d696aea9e1cefca97a760c017a5fde545facaa9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[liach]

/integrate

I shall integrate this improvement, so that I can provide patches that:

1. improve parameterList allocation and parameter immutable list sharing.
2. improve conversion performance from/to descriptor strings (with caching, array sharing).

All of these can benefit the Classfile API.

[openjdk]

@liach
Your change (at version dc2a5a5) is now ready to be sponsored by a Committer.

[mlchung]

/sponsor

[openjdk]

Going to push as commit 8ffa264.
Since your change was applied there have been 486 commits pushed to the master branch:

• 6b27dad: 8301154: SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries
• ed0e956: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
• bddf483: 8303942: os::write should write completely
• ab241b3: 8306706: Support out-of-line code generation for MachNodes
• 710453c: 8308016: Use snippets in java.io package
• e9320f3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
• 97d3b27: 8307523: [vectorapi] Optimize MaskFromLongBenchmark.java
• bb0ff48: 8305091: Change ChaCha20 cipher init behavior to match AES-GCM
• c0c4d77: 8308544: Fix compilation regression from JDK-8306983 on musl libc
• 9e196b3: 8308565: HttpClient: Sanitize logging while stopping
• ... and 476 more: https://git.openjdk.org/jdk/compare/8d696aea9e1cefca97a760c017a5fde545facaa9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung @liach Pushed as commit 8ffa264.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.