New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8248186: Move CDS C++ vtable code to cppVtables.cpp #136
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
@iklam The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
/label remove build,hotspot |
@iklam The |
/label add hotspot-runtime |
@iklam |
#include "oops/instanceClassLoaderKlass.hpp" | ||
#include "oops/instanceMirrorKlass.hpp" | ||
#include "oops/instanceRefKlass.hpp" | ||
#include "oops/methodData.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that you needed all of these #include files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I started with no headers and kept adding until gcc stopped complaining. I was using a non-PCH build.
@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
/integrate |
I moved the code that supports C++ vtables in the CDS archive from metaspaceShared.cpp to a new file, cppVtables.cpp. To keep the refactoring straightforward, the code is moved verbatim, except for:
MetaspaceShared::xx
toCppVtables::xx
_mc_region
is changed to the inline functionmc_region()
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/136/head:pull/136
$ git checkout pull/136