8248186: Move CDS C++ vtable code to cppVtables.cpp

[iklam]

I moved the code that supports C++ vtables in the CDS archive from metaspaceShared.cpp to a new file, cppVtables.cpp. To keep the refactoring straightforward, the code is moved verbatim, except for:

• Methods are renamed from MetaspaceShared::xx to CppVtables::xx
• Access to _mc_region is changed to the inline function mc_region()

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8248186: Move CDS C++ vtable code to cppVtables.cpp

Reviewers

• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to b1db967

Download

$ git fetch https://git.openjdk.java.net/jdk pull/136/head:pull/136
$ git checkout pull/136

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following labels will be automatically applied to this pull request: build hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

[iklam]

/label remove build,hotspot

[openjdk]

@iklam
The build label was successfully removed.

The hotspot label was successfully removed.

[iklam]

/label add hotspot-runtime

[openjdk]

@iklam
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 01: Full (b50eb99)
• 00: Full (b1db967)

[coleenp]

Did you check that you needed all of these #include files?

[iklam]

Yes, I started with no headers and kept adding until gcc stopped complaining. I was using a non-PCH build.

[openjdk]

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8248186: Move CDS C++ vtable code to cppVtables.cpp

Reviewed-by: coleenp

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 03a4df0acd103702e52dcd01c3f03fda4d7b04f5.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

/integrate

[openjdk]

@iklam Pushed as commit c5e63b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.