Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298189: Regression in SPECjvm2008-MonteCarlo for pre-Cascade Lake Intel processors #13605

Closed
wants to merge 1 commit into from

Conversation

robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Apr 24, 2023

The mov + inc/dec -> lea subset of the peephole rules introduced by JDK-8283699 has been found to cause minor regressions for some common benchmarks on Intel microarchitectures earlier than Cascade Lake. This changeset limits their application to Intel Cascade Lake and microarchitectures with full ALU support for lea (VM_Version::supports_fast_3op_lea()), where these peephole rules have been confirmed to be beneficial. The adjustment speeds up SPECjvm2008's MonteCarlo benchmark by between 0.1% and 2.7% on pre-Cascade Lake microarchitectures (Haswell-DT, Coffee Lake-B) across different garbage collectors (G1, ZGC). It additionally yields a speedup of 2.1% on SPECjvm2008's Derby benchmark when using G1 on Coffee Lake-B.

Thanks to @ericcaspole for discussions and helping out with benchmarking.

Testing

Functionality
  • tier1-5 (windows-x64, linux-x64, macosx-x64; release and debug mode).
  • Checked that the expected combination of peephole rules is enabled for all microarchitectures supported by Intel's Software Development Emulator 9.0.
Performance
  • Tested performance on a set of standard benchmark suites (DaCapo, SPECjbb2015, SPECjvm2008), different Intel microarchitectures (Haswell-DT, Coffee Lake-B, Cascade Lake, Ice Lake-SP) and operating systems (linux-x64, windows-x64, and macosx-x64). No significant change was observed besides the improvements mentioned above.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298189: Regression in SPECjvm2008-MonteCarlo for pre-Cascade Lake Intel processors

Reviewers

Contributors

  • Quan Anh Mai <qamai@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13605/head:pull/13605
$ git checkout pull/13605

Update a local copy of the PR:
$ git checkout pull/13605
$ git pull https://git.openjdk.org/jdk.git pull/13605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13605

View PR using the GUI difftool:
$ git pr show -t 13605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13605.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2023

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@robcasloz
Copy link
Contributor Author

/contributor add @merykitty

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robcasloz
Contributor Quan Anh Mai <qamai@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robcasloz The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 24, 2023
@robcasloz
Copy link
Contributor Author

/label remove hotspot

@robcasloz
Copy link
Contributor Author

/label add hotspot-compiler

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robcasloz
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robcasloz
The hotspot-compiler label was successfully added.

@robcasloz robcasloz marked this pull request as ready for review April 24, 2023 07:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me.

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298189: Regression in SPECjvm2008-MonteCarlo for pre-Cascade Lake Intel processors

Co-authored-by: Quan Anh Mai <qamai@openjdk.org>
Reviewed-by: shade, thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

  • 328e512: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp
  • 937dd34: 8306775: Problemlist runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java
  • 314db55: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected
  • 6b81342: 8305994: Guarantee eventual async monitor deflation
  • 41d6be4: 8301065: Handle control characters in java_lang_String::print
  • 4b23bef: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • f32adaf: 8304836: Make MALLOC_MIN4 macro more robust
  • 2763cf1: 8304896: Update to use jtreg 7.2
  • b2ccc97: 8306444: Don't leak memory in PhaseChaitin::PhaseChaitin
  • d980cb4: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
  • ... and 174 more: https://git.openjdk.org/jdk/compare/9e20382311c58bd172abc98bc0a6757c3a64dda1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 24, 2023
@robcasloz
Copy link
Contributor Author

This looks okay to me.

Thanks for reviewing, Aleksey!

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in nailing this down! The fix looks reasonable to me.

@robcasloz
Copy link
Contributor Author

Good job in nailing this down! The fix looks reasonable to me.

Thanks, Tobias!

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@robcasloz
Copy link
Contributor Author

Good.

Thanks for reviewing, Vladimir!

@robcasloz
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

Going to push as commit 8d89992.
Since your change was applied there have been 222 commits pushed to the master branch:

  • 44d9f55: 8306072: Open source several AWT MouseInfo related tests
  • cc894d8: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • ed1ebd2: 8306652: Open source AWT MenuItem related tests
  • f3e8bd1: 8306755: Open source few Swing JComponent and AbstractButton tests
  • 1c1a73f: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API
  • adf62fe: 8304918: Remove unused decl field from AnnotatedType implementations
  • 00b1eac: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
  • 88d9ebf: 8306752: Open source several container and component AWT tests
  • 1c2dadc: 8306683: Open source several clipboard and color AWT tests
  • b372f28: 8306753: Open source several container AWT tests
  • ... and 212 more: https://git.openjdk.org/jdk/compare/9e20382311c58bd172abc98bc0a6757c3a64dda1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2023
@openjdk openjdk bot closed this Apr 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@robcasloz Pushed as commit 8d89992.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants