Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306714: Open source few Swing event and AbstractAction tests #13608

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 24, 2023

This opensources few Swing event and AbstractAction tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306714: Open source few Swing event and AbstractAction tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13608/head:pull/13608
$ git checkout pull/13608

Update a local copy of the PR:
$ git checkout pull/13608
$ git pull https://git.openjdk.org/jdk.git pull/13608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13608

View PR using the GUI difftool:
$ git pr show -t 13608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13608.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 24, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306714: Open source few Swing event and AbstractAction tests

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 200 new commits pushed to the master branch:

  • 2ea62c1: 8303276: Secondary assertion failure in AdapterHandlerLibrary::contains during crash reporting
  • 0dc03c9: 8305922: [aix,linux] Avoid comparing 'this' to nullptr
  • 328e512: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp
  • 937dd34: 8306775: Problemlist runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java
  • 314db55: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected
  • 6b81342: 8305994: Guarantee eventual async monitor deflation
  • 41d6be4: 8301065: Handle control characters in java_lang_String::print
  • 4b23bef: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • f32adaf: 8304836: Make MALLOC_MIN4 macro more robust
  • 2763cf1: 8304896: Update to use jtreg 7.2
  • ... and 190 more: https://git.openjdk.org/jdk/compare/ce10460e94c03f178943fa44dafae18acc480094...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 24, 2023
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

Going to push as commit 31a73b0.
Since your change was applied there have been 204 commits pushed to the master branch:

  • 8063aa2: 8306695: Divide by zero in G1Policy::logged_cards_processing_time
  • 2471919: 8304036: Use CommandLine class from shared module
  • f39641c: 8306682: Open source a few more AWT Choice tests
  • b5362da: 8306484: Open source several AWT Choice jtreg tests
  • 2ea62c1: 8303276: Secondary assertion failure in AdapterHandlerLibrary::contains during crash reporting
  • 0dc03c9: 8305922: [aix,linux] Avoid comparing 'this' to nullptr
  • 328e512: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp
  • 937dd34: 8306775: Problemlist runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java
  • 314db55: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected
  • 6b81342: 8305994: Guarantee eventual async monitor deflation
  • ... and 194 more: https://git.openjdk.org/jdk/compare/ce10460e94c03f178943fa44dafae18acc480094...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2023
@openjdk openjdk bot closed this Apr 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@prsadhuk Pushed as commit 31a73b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8306714 branch April 25, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants