Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306560: Add TOOLING.jsh load file #13609

Closed
wants to merge 5 commits into from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Apr 24, 2023

This PR adds the TOOLING.jsh load file for being used in jshell TOOLING commands.

Man page update is pending...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8308853 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13609/head:pull/13609
$ git checkout pull/13609

Update a local copy of the PR:
$ git checkout pull/13609
$ git pull https://git.openjdk.org/jdk.git pull/13609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13609

View PR using the GUI difftool:
$ git pr show -t 13609

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13609.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2023

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@sormuras The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Apr 24, 2023
@sormuras sormuras marked this pull request as ready for review April 25, 2023 14:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

@sormuras This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed csr Pull request needs approved CSR before integration labels May 25, 2023
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306560: Add TOOLING.jsh load file

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 530 new commits pushed to the master branch:

  • 199b1bf: 8308583: SIGSEGV in GraphKit::gen_checkcast
  • 46c4da7: 8159023: Engineering notation of DecimalFormat does not work as documented
  • ee321c7: 8308907: ProblemList java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on linux-x64
  • dc7683a: 8308073: ClassLoaderExt::append_boot_classpath should handle dynamic archive
  • 4870234: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
  • 7d2a7ce: 8308672: Add version number in the replay file generated by DumpInline
  • 27ba8bd: 8308108: Support Unicode extension for collation settings
  • 89b3c37: 8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations
  • 98acce1: 8306703: JFR: Summary views
  • 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
  • ... and 520 more: https://git.openjdk.org/jdk/compare/30fa50d15854ffaec2f17882710e9f09f829b77a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2023
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2023

Going to push as commit 547a8b4.
Since your change was applied there have been 547 commits pushed to the master branch:

  • ca54f4e: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
  • 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
  • bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads
  • a923634: 8286470: Support searching for sections in class/package javadoc
  • 55d297f: 8308594: Use atomic bitset function for PackageEntry::_defined_by_cds_in_class_path
  • c72b547: 8308801: update for deprecated sprintf for libnet in java.base
  • 77c5adb: 8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage
  • ce5251a: 8308657: ReplayInline is not availabe in production build
  • cc0976b: 8308589: gc/cslocker/TestCSLocker.java timed out
  • 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
  • ... and 537 more: https://git.openjdk.org/jdk/compare/30fa50d15854ffaec2f17882710e9f09f829b77a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2023
@openjdk openjdk bot closed this May 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2023
@openjdk
Copy link

openjdk bot commented May 28, 2023

@sormuras Pushed as commit 547a8b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants