8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region

[tschatzl]

Hi all,

after JDK-8298048 G1DetermineCompactionQueueClosure::free_pinned_region() may only be called with humongous regions, so the template parameter is unnecessary. This PR removes it.
I kept the method itself (not inlined) because I believe its name acts as a good documentation what is done here at the place it is called, even if it's only 3 LOC.

Testing: local compilation, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13610/head:pull/13610
$ git checkout pull/13610

Update a local copy of the PR:
$ git checkout pull/13610
$ git pull https://git.openjdk.org/jdk.git pull/13610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13610

View PR using the GUI difftool:
$ git pr show -t 13610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13610.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5ec05c71)

[albertnetymk]

Inlining it is more readable, IMO. For example, it's not obvious whether add_to_compaction_queue should be the caller or the callee.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• f239695: 8305056: Avoid unaligned access in emit_intX methods if it's unsupported
• 136dad7: 8306566: Open source several clipboard AWT tests
• 30fa50d: 8305062: Refactor CardTable::resize_covered_region

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks for your reviews.

/integrate

[openjdk]

Going to push as commit a4a5385.
Since your change was applied there have been 26 commits pushed to the master branch:

• a98f587: 8306766: Reduce heap size for TestJNICriticalStressTest
• d53a5ee: 8306067: Open source AWT Graphics,GridBagLayout related tests
• f968da9: 8305352: updateIconImages may lead to deadlock after JDK-8276849
• 2985738: 8306773: Problemlist jdk/incubator/vector/ShortMaxVectorTests.java on x86_32
• 31a73b0: 8306714: Open source few Swing event and AbstractAction tests
• 8063aa2: 8306695: Divide by zero in G1Policy::logged_cards_processing_time
• 2471919: 8304036: Use CommandLine class from shared module
• f39641c: 8306682: Open source a few more AWT Choice tests
• b5362da: 8306484: Open source several AWT Choice jtreg tests
• 2ea62c1: 8303276: Secondary assertion failure in AdapterHandlerLibrary::contains during crash reporting
• ... and 16 more: https://git.openjdk.org/jdk/compare/4a9f8efa867f84463f054d6624bcc5a89033e152...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit a4a5385.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.