8306749: Make CardTable::invalidate non-virtual

[albertnetymk]

Trivial removing unused virtual specifier.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306749: Make CardTable::invalidate non-virtual

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13617/head:pull/13617
$ git checkout pull/13617

Update a local copy of the PR:
$ git checkout pull/13617
$ git pull https://git.openjdk.org/jdk.git pull/13617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13617

View PR using the GUI difftool:
$ git pr show -t 13617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13617.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2514f190)

[tschatzl]

Lgtm and trivial.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306749: Make CardTable::invalidate non-virtual

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• a4a5385: 8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region
• a98f587: 8306766: Reduce heap size for TestJNICriticalStressTest
• d53a5ee: 8306067: Open source AWT Graphics,GridBagLayout related tests
• f968da9: 8305352: updateIconImages may lead to deadlock after JDK-8276849
• 2985738: 8306773: Problemlist jdk/incubator/vector/ShortMaxVectorTests.java on x86_32
• 31a73b0: 8306714: Open source few Swing event and AbstractAction tests
• 8063aa2: 8306695: Divide by zero in G1Policy::logged_cards_processing_time
• 2471919: 8304036: Use CommandLine class from shared module
• f39641c: 8306682: Open source a few more AWT Choice tests
• b5362da: 8306484: Open source several AWT Choice jtreg tests
• ... and 16 more: https://git.openjdk.org/jdk/compare/30fa50d15854ffaec2f17882710e9f09f829b77a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit c5910fa.
Since your change was applied there have been 55 commits pushed to the master branch:

• 86f41a4: 8306735: G1: G1FullGCScope remove unnecessary member _explicit_gc
• d747698: 8306823: Native memory leak in SharedRuntime::notify_jvmti_unmount/mount.
• 8d89992: 8298189: Regression in SPECjvm2008-MonteCarlo for pre-Cascade Lake Intel processors
• 44d9f55: 8306072: Open source several AWT MouseInfo related tests
• cc894d8: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• ed1ebd2: 8306652: Open source AWT MenuItem related tests
• f3e8bd1: 8306755: Open source few Swing JComponent and AbstractButton tests
• 1c1a73f: 8302908: RISC-V: Support masked vector arithmetic instructions for Vector API
• adf62fe: 8304918: Remove unused decl field from AnnotatedType implementations
• 00b1eac: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
• ... and 45 more: https://git.openjdk.org/jdk/compare/30fa50d15854ffaec2f17882710e9f09f829b77a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit c5910fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.