8289735: UTIL_LOOKUP_PROGS fails on pathes with space

[RealCLanger]

This is an attempt to fix the issue on Windows when no cygwin Git is installed or the Git for Windows installation has precedence in PATH lookup. The path to the Windows GIT installation usually resides in C:\Program Files which contains a space and thus needs some special handling.

There exists code in UTIL_LOOKUP_PROGS/UTIL_FIXUP_EXECUTABLE that would handle this. However, it relies on initializations made in PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET and BASIC_SETUP_PATHS. Currently, UTIL_LOOKUP_PROGS(GIT, git) is called too early in configure and hence the problematic Windows path is not handled correctly. My fix makes sure that only the barely necessary tool lookups required for PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET and BASIC_SETUP_PATHS are made in BASIC_SETUP_FUNDAMENTAL_TOOLS and everything else is moved into another macro called BASIC_SETUP_TOOLS that is invoked after path handling is set up correctly, which includes the lookup of git.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289735: UTIL_LOOKUP_PROGS fails on pathes with space

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13629/head:pull/13629
$ git checkout pull/13629

Update a local copy of the PR:
$ git checkout pull/13629
$ git pull https://git.openjdk.org/jdk.git pull/13629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13629

View PR using the GUI difftool:
$ git pr show -t 13629

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13629.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0f875899)
• 00: Full (e4890a96)

[erikj79]

I think this change makes sense. Given how small this set of tools is now, I think we should add a comment on PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET in platform.m4 saying something about needing to be careful to only use tools setup in BASIC_SETUP_FUNDAMENTAL_TOOLS.

[RealCLanger]

I think this change makes sense. Given how small this set of tools is now, I think we should add a comment on PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET in platform.m4 saying something about needing to be careful to only use tools setup in BASIC_SETUP_FUNDAMENTAL_TOOLS.

Right, and the same comment for BASIC_SETUP_PATHS. Will update the comments...

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289735: UTIL_LOOKUP_PROGS fails on pathes with space

Reviewed-by: erikj, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• f968da9: 8305352: updateIconImages may lead to deadlock after JDK-8276849
• 2985738: 8306773: Problemlist jdk/incubator/vector/ShortMaxVectorTests.java on x86_32
• 31a73b0: 8306714: Open source few Swing event and AbstractAction tests
• 8063aa2: 8306695: Divide by zero in G1Policy::logged_cards_processing_time
• 2471919: 8304036: Use CommandLine class from shared module
• f39641c: 8306682: Open source a few more AWT Choice tests
• b5362da: 8306484: Open source several AWT Choice jtreg tests
• 2ea62c1: 8303276: Secondary assertion failure in AdapterHandlerLibrary::contains during crash reporting
• 0dc03c9: 8305922: [aix,linux] Avoid comparing 'this' to nullptr
• 328e512: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp
• ... and 5 more: https://git.openjdk.org/jdk/compare/f32adaf89fede5262db2cb5517fc649a87e0714d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit bad6aa6.
Since your change was applied there have been 20 commits pushed to the master branch:

• 5f50e99: 8306770: (fs) Remove obsolete os.version check from sun.nio.fs.BsdFileStore.supportsFileAttributeView
• 9d1fe65: 8306740: G1: Change G1CardSetHashTableScan to lambda
• a4a5385: 8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region
• a98f587: 8306766: Reduce heap size for TestJNICriticalStressTest
• d53a5ee: 8306067: Open source AWT Graphics,GridBagLayout related tests
• f968da9: 8305352: updateIconImages may lead to deadlock after JDK-8276849
• 2985738: 8306773: Problemlist jdk/incubator/vector/ShortMaxVectorTests.java on x86_32
• 31a73b0: 8306714: Open source few Swing event and AbstractAction tests
• 8063aa2: 8306695: Divide by zero in G1Policy::logged_cards_processing_time
• 2471919: 8304036: Use CommandLine class from shared module
• ... and 10 more: https://git.openjdk.org/jdk/compare/f32adaf89fede5262db2cb5517fc649a87e0714d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit bad6aa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.