Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257208: Fix typo in doc/building.md #1365

Closed
wants to merge 1 commit into from
Closed

8257208: Fix typo in doc/building.md #1365

wants to merge 1 commit into from

Conversation

@HollowMan6
Copy link
Contributor

@HollowMan6 HollowMan6 commented Nov 21, 2020

overriden -> overridden


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1365/head:pull/1365
$ git checkout pull/1365

@bridgekeeper bridgekeeper bot added the oca label Nov 21, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 21, 2020

Hi @HollowMan6, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user HollowMan6" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 21, 2020

@HollowMan6 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Nov 21, 2020
@bridgekeeper bridgekeeper bot removed the oca label Nov 24, 2020
@magicus
Copy link
Member

@magicus magicus commented Nov 27, 2020

Hi @HollowMan6!

Thank you for submitting this PR. As the contribution docs state, you need a sponsor for this PR. I'll be your sponsor.

I have opened a bug issue for this fix: https://bugs.openjdk.java.net/browse/JDK-8257208

Please update the PR title to 8257208: Fix typo in doc/building.md.

Loading

Signed-off-by: Hollow Man <hollowman@hollowman.ml>
@HollowMan6 HollowMan6 changed the title Fix typo 8257208: Fix typo in doc/building.md Nov 27, 2020
@openjdk openjdk bot added the rfr label Nov 27, 2020
@HollowMan6
Copy link
Contributor Author

@HollowMan6 HollowMan6 commented Nov 27, 2020

Hi @HollowMan6!

Thank you for submitting this PR. As the contribution docs state, you need a sponsor for this PR. I'll be your sponsor.

I have opened a bug issue for this fix: https://bugs.openjdk.java.net/browse/JDK-8257208

Please update the PR title to 8257208: Fix typo in doc/building.md.

@magicus Done! Thanks.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 27, 2020

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@HollowMan6 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257208: Fix typo in doc/building.md

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • 5be4de8: 8245058: improve presentation of annotations for modules and packages
  • d51e2ab: 8256986: [PPC64] C2 crashes when accessing nonexisting jvms of CallLeafDirectNode
  • 644271e: 8248566: Make API docs more usable on mobile browsers
  • 53d1444: 8244535: JavaDoc search is overly strict with letter case
  • 78fdb65: 8254893: Fix display of search tag results without holder information
  • 20525d2: 8257149: Improve G1 Service thread task scheduling to guarantee task delay
  • f2f3ba9: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript
  • ee99686: 8252645: Change time measurements in G1ServiceThread to only account remembered set work
  • a3eec39: 8257181: s390x builds are very noisy with gc-sections messages
  • 9a468d8: 8256757: Incorrect MachCallRuntimeNode::ret_addr_offset() for CallLeafNoFP on x86_32
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/9a19eb6918e1f766ccf1b1671ea1161a76fee571...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Nov 27, 2020
@HollowMan6
Copy link
Contributor Author

@HollowMan6 HollowMan6 commented Nov 27, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@HollowMan6
Your change (at version 1c02605) is now ready to be sponsored by a Committer.

Loading

@HollowMan6
Copy link
Contributor Author

@HollowMan6 HollowMan6 commented Nov 27, 2020

@magicus Thanks for reviewing! Now could you please sponsor this change? Thanks!

Loading

@magicus
Copy link
Member

@magicus magicus commented Nov 27, 2020

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@magicus @HollowMan6 Since your change was applied there have been 103 commits pushed to the master branch:

  • b4cba15: 8170432: Class java.util.UUID & @OverRide
  • 5be4de8: 8245058: improve presentation of annotations for modules and packages
  • d51e2ab: 8256986: [PPC64] C2 crashes when accessing nonexisting jvms of CallLeafDirectNode
  • 644271e: 8248566: Make API docs more usable on mobile browsers
  • 53d1444: 8244535: JavaDoc search is overly strict with letter case
  • 78fdb65: 8254893: Fix display of search tag results without holder information
  • 20525d2: 8257149: Improve G1 Service thread task scheduling to guarantee task delay
  • f2f3ba9: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript
  • ee99686: 8252645: Change time measurements in G1ServiceThread to only account remembered set work
  • a3eec39: 8257181: s390x builds are very noisy with gc-sections messages
  • ... and 93 more: https://git.openjdk.java.net/jdk/compare/9a19eb6918e1f766ccf1b1671ea1161a76fee571...master

Your commit was automatically rebased without conflicts.

Pushed as commit f6bfbb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants