-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8306466: Open source more AWT Drag & Drop related tests #13653
Conversation
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
Webrevs
|
The 1st 4 of these tests do not need their own directories since they are single file tests. The extra folder can be dropped |
Sure, I removed the folders and placed the tests directly into the dnd folder. |
} | ||
} | ||
|
||
if (incorrectActionDetected) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrectActionDetected is set on one thread an used on another, same for "frame" in other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meaning you are suggesting they need to be volatile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or changed to be used on the same thread, in this case EDT. It seems different tests use different approaches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this var volatile and put the frame blocks in the EDT. Should all be fixed
|
||
public void init() { | ||
sourceFrame = new SourceFrame(); | ||
targetFrame = new TargetFrame(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
targetFrame = new TargetFrame(); | |
targetFrame = new TargetFrame(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
||
public void dragDropEnd(DragSourceDropEvent dsde) { } | ||
|
||
public void dragGestureRecognized(DragGestureEvent dge) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public void dragGestureRecognized(DragGestureEvent dge) { | |
public void dragGestureRecognized(DragGestureEvent dge) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
public TransferableObject(Object data) { | ||
super(); | ||
Vector v = new Vector(); | ||
if(data instanceof String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange indentation
if(data instanceof String) { | |
if (data instanceof String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 196 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 418a825.
Your commit was automatically rebased without conflicts. |
This PR open sources a few more AWT DnD related tests
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13653/head:pull/13653
$ git checkout pull/13653
Update a local copy of the PR:
$ git checkout pull/13653
$ git pull https://git.openjdk.org/jdk.git pull/13653/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13653
View PR using the GUI difftool:
$ git pr show -t 13653
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13653.diff
Webrev
Link to Webrev Comment