Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306466: Open source more AWT Drag & Drop related tests #13653

Closed

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Apr 25, 2023

This PR open sources a few more AWT DnD related tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306466: Open source more AWT Drag & Drop related tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13653/head:pull/13653
$ git checkout pull/13653

Update a local copy of the PR:
$ git checkout pull/13653
$ git pull https://git.openjdk.org/jdk.git pull/13653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13653

View PR using the GUI difftool:
$ git pr show -t 13653

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13653.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@prrace
Copy link
Contributor

prrace commented Apr 25, 2023

The 1st 4 of these tests do not need their own directories since they are single file tests. The extra folder can be dropped

@DamonGuy
Copy link
Contributor Author

The 1st 4 of these tests do not need their own directories since they are single file tests. The extra folder can be dropped

Sure, I removed the folders and placed the tests directly into the dnd folder.

}
}

if (incorrectActionDetected) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrectActionDetected is set on one thread an used on another, same for "frame" in other tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meaning you are suggesting they need to be volatile ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or changed to be used on the same thread, in this case EDT. It seems different tests use different approaches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this var volatile and put the frame blocks in the EDT. Should all be fixed


public void init() {
sourceFrame = new SourceFrame();
targetFrame = new TargetFrame();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
targetFrame = new TargetFrame();
targetFrame = new TargetFrame();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


public void dragDropEnd(DragSourceDropEvent dsde) { }

public void dragGestureRecognized(DragGestureEvent dge) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void dragGestureRecognized(DragGestureEvent dge) {
public void dragGestureRecognized(DragGestureEvent dge) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

public TransferableObject(Object data) {
super();
Vector v = new Vector();
if(data instanceof String) {
Copy link
Member

@turbanoff turbanoff Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indentation

Suggested change
if(data instanceof String) {
if (data instanceof String) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306466: Open source more AWT Drag & Drop related tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 196 new commits pushed to the master branch:

  • 4818c79: 8307110: zero build broken after JDK-8304265
  • da9efee: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException
  • 05af487: 8306681: Open source more AWT DnD related tests
  • ec5c792: 8306133: Open source few AWT Drag & Drop related tests
  • 6d6f726: 8307078: Opensource and clean up five more AWT Focus related tests
  • 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
  • f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
  • 82ccfe3: 8305975: Add TWCA Global Root CA
  • a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
  • ... and 186 more: https://git.openjdk.org/jdk/compare/6831f9db8b978a441ef38d3602779c3a5f521413...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2023
@DamonGuy
Copy link
Contributor Author

DamonGuy commented May 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2023

Going to push as commit 418a825.
Since your change was applied there have been 235 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2023
@openjdk openjdk bot closed this May 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@DamonGuy Pushed as commit 418a825.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants