8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails

[RogerRiggs]

It appears that -Xcomp causes the relative timing of the commands to be disturbed enough to prevent the correct operation of the test. The test should not be run with -Xcomp

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails

Reviewers

• Brent Christian (@bchristi-git - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13660/head:pull/13660
$ git checkout pull/13660

Update a local copy of the PR:
$ git checkout pull/13660
$ git pull https://git.openjdk.org/jdk.git pull/13660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13660

View PR using the GUI difftool:
$ git pr show -t 13660

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13660.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ad2d13ea)
• 00: Full (e66b4970)

[bchristi-git]

How about vm.compMode != "Xcomp" ?

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails

Reviewed-by: bchristi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 6983d05: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.
• 80fae51: 8306959: (bf) CharBuffer.append(CharSequence,int,int) throws BufferOverflowException where IndexOutOfBoundsException expected
• eb35861: 8205592: BigDecimal.doubleValue() is depressingly slow
• 41ba05e: 8306850: Open source AWT Model related tests
• fed262a: 8306949: Resolve miscellaneous multiple symbol definition issues when statically linking JDK/VM natives with standard launcher
• 96cdf93: 8306833: Change CardTable::_covered to static array
• 1be80a4: 8287087: C2: perform SLP reduction analysis on-demand
• ba43649: 8306976: UTIL_REQUIRE_SPECIAL warning on grep
• cbccc4c: 8304265: Implementation of Foreign Function and Memory API (Third Preview)
• 41d5853: 8306940: test/jdk/java/net/httpclient/XxxxInURI.java should call HttpClient::close
• ... and 30 more: https://git.openjdk.org/jdk/compare/00b1eacad6ae2d5ea5afb1de506768e9ab960743...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit b827ce8.
Since your change was applied there have been 41 commits pushed to the master branch:

• 7871390: 8306952: improve generic signature of internal DCInlineTag class
• 6983d05: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.
• 80fae51: 8306959: (bf) CharBuffer.append(CharSequence,int,int) throws BufferOverflowException where IndexOutOfBoundsException expected
• eb35861: 8205592: BigDecimal.doubleValue() is depressingly slow
• 41ba05e: 8306850: Open source AWT Model related tests
• fed262a: 8306949: Resolve miscellaneous multiple symbol definition issues when statically linking JDK/VM natives with standard launcher
• 96cdf93: 8306833: Change CardTable::_covered to static array
• 1be80a4: 8287087: C2: perform SLP reduction analysis on-demand
• ba43649: 8306976: UTIL_REQUIRE_SPECIAL warning on grep
• cbccc4c: 8304265: Implementation of Foreign Function and Memory API (Third Preview)
• ... and 31 more: https://git.openjdk.org/jdk/compare/00b1eacad6ae2d5ea5afb1de506768e9ab960743...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit b827ce8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.