Skip to content

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Apr 25, 2023

Update PSL for JDK 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13662/head:pull/13662
$ git checkout pull/13662

Update a local copy of the PR:
$ git checkout pull/13662
$ git pull https://git.openjdk.org/jdk.git pull/13662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13662

View PR using the GUI difftool:
$ git pr show -t 13662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13662.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@wangweij
Copy link
Contributor Author

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@wangweij
The core-libs label was successfully removed.

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302182: Update Public Suffix List to 88467c9

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 8e36c05: 8305853: java/text/Format/DateFormat/DateFormatRegression.java fails with "Uncaught exception thrown in test method Test4089106"
  • d0e8aec: 8306374: (bf) Improve performance of DirectCharBuffer::append(CharSequence[,int,int])
  • a18191f: 8302328: [s390x] Simplify asm_assert definition
  • 9bc6a21: 8306033: Resolve multiple definition of 'throwIOException' and friends when statically linking with JDK native libraries
  • 35e8023: 8306872: Rename Node_Array::Size()
  • 2e340e8: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
  • 35e7bc2: 8306855: [s390x] fix difference in abi sizes
  • 9ad6dc8: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable
  • c5910fa: 8306749: Make CardTable::invalidate non-virtual
  • 86f41a4: 8306735: G1: G1FullGCScope remove unnecessary member _explicit_gc
  • ... and 42 more: https://git.openjdk.org/jdk/compare/314db55f6dde033f62481b62f10dd11030473569...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2023
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

Going to push as commit 01b8512.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 8e36c05: 8305853: java/text/Format/DateFormat/DateFormatRegression.java fails with "Uncaught exception thrown in test method Test4089106"
  • d0e8aec: 8306374: (bf) Improve performance of DirectCharBuffer::append(CharSequence[,int,int])
  • a18191f: 8302328: [s390x] Simplify asm_assert definition
  • 9bc6a21: 8306033: Resolve multiple definition of 'throwIOException' and friends when statically linking with JDK native libraries
  • 35e8023: 8306872: Rename Node_Array::Size()
  • 2e340e8: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time
  • 35e7bc2: 8306855: [s390x] fix difference in abi sizes
  • 9ad6dc8: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable
  • c5910fa: 8306749: Make CardTable::invalidate non-virtual
  • 86f41a4: 8306735: G1: G1FullGCScope remove unnecessary member _explicit_gc
  • ... and 42 more: https://git.openjdk.org/jdk/compare/314db55f6dde033f62481b62f10dd11030473569...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2023
@openjdk openjdk bot closed this Apr 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@wangweij Pushed as commit 01b8512.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8302182 branch April 27, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants