Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306640: Open source several AWT TextArea related tests #13670

Closed
wants to merge 1 commit into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Apr 26, 2023

Open source few AWT TextArea related tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306640: Open source several AWT TextArea related tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13670/head:pull/13670
$ git checkout pull/13670

Update a local copy of the PR:
$ git checkout pull/13670
$ git pull https://git.openjdk.org/jdk.git pull/13670/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13670

View PR using the GUI difftool:
$ git pr show -t 13670

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13670.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2023

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 26, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2023

Webrevs

/*
@test
@bug 5025532
@requires (os.family == "windows")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test can pass on windows only or we can run it on all platform?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was raised for windows alone, I think the test can be run on all platforms, haven't checked though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest checking and deleting this if the tests will work fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will check that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is is failing for both linux and macos. Maybe because of \r\n direct check, so better to leave the test for windows alone.

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306640: Open source several AWT TextArea related tests

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 592 new commits pushed to the master branch:

  • d3abfec: 8305566: Change StringDedup thread to derive from JavaThread
  • f3c90f0: 8306711: Improve diagnosis of IntlTest framework
  • b827ce8: 8298993: (process) java/lang/ProcessBuilder/UnblockSignals.java fails
  • 7871390: 8306952: improve generic signature of internal DCInlineTag class
  • 6983d05: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.
  • 80fae51: 8306959: (bf) CharBuffer.append(CharSequence,int,int) throws BufferOverflowException where IndexOutOfBoundsException expected
  • eb35861: 8205592: BigDecimal.doubleValue() is depressingly slow
  • 41ba05e: 8306850: Open source AWT Model related tests
  • fed262a: 8306949: Resolve miscellaneous multiple symbol definition issues when statically linking JDK/VM natives with standard launcher
  • 96cdf93: 8306833: Change CardTable::_covered to static array
  • ... and 582 more: https://git.openjdk.org/jdk/compare/431e702b676e2c02224d60181c34b5fe97873d8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2023
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

Going to push as commit 169a7c2.
Since your change was applied there have been 601 commits pushed to the master branch:

  • 5d9baa2: 8306672: support offset in dll_address_to_library_name on AIX
  • 83a98c6: 8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails
  • 452cb84: 8307103: Two TestMetaspaceAllocationMT tests fail after JDK-8306696
  • fee02f0: 8299748: java/util/zip/Deinflate.java failing on s390x
  • 60a29a6: 8305387: JDK-8301995 breaks arm 32-bit
  • 3d9d84b: 8307006: ProblemList gtest/NMTGtest.java on aix
  • 84df74c: 8305079: Remove finalize() from compiler/c2/Test719030
  • 0b5c504: 8306696: Remove MetaspaceReclaimPolicy=aggressive and obsolete MetaspaceReclaimPolicy
  • eb3af8a: 8306901: Macro offset_of confuses Eclipse CDT
  • d3abfec: 8305566: Change StringDedup thread to derive from JavaThread
  • ... and 591 more: https://git.openjdk.org/jdk/compare/431e702b676e2c02224d60181c34b5fe97873d8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2023
@openjdk openjdk bot closed this Apr 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@TejeshR13 Pushed as commit 169a7c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants