Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306976: UTIL_REQUIRE_SPECIAL warning on grep #13685

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented Apr 27, 2023

hi

bash configure

There is an warning message

The following warnings were produced. Repeated here for convenience:
WARNING: Ignoring value of GREP from the environment. Use command line variables instead. 

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13685/head:pull/13685
$ git checkout pull/13685

Update a local copy of the PR:
$ git checkout pull/13685
$ git pull https://git.openjdk.org/jdk.git pull/13685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13685

View PR using the GUI difftool:
$ git pr show -t 13685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13685.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2023

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@xpbob The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 27, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2023

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, I must have overlooked this. Looks good, thanks for fixing.

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306976: UTIL_REQUIRE_SPECIAL warning on grep

Reviewed-by: clanger, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • cbccc4c: 8304265: Implementation of Foreign Function and Memory API (Third Preview)
  • 41d5853: 8306940: test/jdk/java/net/httpclient/XxxxInURI.java should call HttpClient::close
  • d94ce65: 8306858: Remove some remnants of CMS from SA agent
  • a83c02f: 8306654: Disable NMT location_printing_cheap_dead_xx tests again
  • de0c05d: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr
  • 748476f: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
  • 27c5c10: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger, @MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2023
@xpbob
Copy link
Contributor Author

xpbob commented Apr 27, 2023

@RealCLanger @MBaesken
Thanks for the review.

@xpbob
Copy link
Contributor Author

xpbob commented Apr 27, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@xpbob
Your change (at version 3eafd7f) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

Going to push as commit ba43649.
Since your change was applied there have been 7 commits pushed to the master branch:

  • cbccc4c: 8304265: Implementation of Foreign Function and Memory API (Third Preview)
  • 41d5853: 8306940: test/jdk/java/net/httpclient/XxxxInURI.java should call HttpClient::close
  • d94ce65: 8306858: Remove some remnants of CMS from SA agent
  • a83c02f: 8306654: Disable NMT location_printing_cheap_dead_xx tests again
  • de0c05d: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr
  • 748476f: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
  • 27c5c10: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2023
@openjdk openjdk bot closed this Apr 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@DamonFool @xpbob Pushed as commit ba43649.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
4 participants