Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8303056: Improve support for Unicode characters and digits in JavaDoc search #13690

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Apr 27, 2023

Please review a change to make JavaDoc search Unicode-aware and better handle elements and index items with digits in their names. The most significant change is to use Unicode property escapes in regular expressions in the search script, but a few other changes were needed. In addition to running the updated test I did extensive manual testing on multiple desktop and mobile browsers to make sure search behavior did not change for other cases.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8306303 to be approved

Issues

  • JDK-8303056: Improve support for Unicode characters and digits in JavaDoc search (Bug - P4)
  • JDK-8306303: Improve support for Unicode characters and digits in JavaDoc search (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13690/head:pull/13690
$ git checkout pull/13690

Update a local copy of the PR:
$ git checkout pull/13690
$ git pull https://git.openjdk.org/jdk.git pull/13690/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13690

View PR using the GUI difftool:
$ git pr show -t 13690

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13690.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2023

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Apr 27, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2023

Webrevs

@hns
Copy link
Member Author

hns commented Apr 28, 2023

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@hns has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@hns please create a CSR request for issue JDK-8303056 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hns hns closed this Jun 6, 2023
@hns hns reopened this Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303056: Improve support for Unicode characters and digits in JavaDoc search

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1330 new commits pushed to the master branch:

  • 509f80b: 8313889: Fix -Wconversion warnings in foreign benchmarks
  • 5c3041c: 8313435: Clean up unused default methods code
  • 8752d49: 8313785: Fix -Wconversion warnings in prims code
  • 41bdcde: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown
  • 091e65e: 8313552: Fix -Wconversion warnings in JFR code
  • 7e20952: 8140326: G1: Consider putting regions where evacuation failed into next collection set
  • 28fd7a1: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
  • a1115a7: 8312204: unexpected else with statement causes compiler crash
  • 87a6acb: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
  • 87b08b6: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
  • ... and 1320 more: https://git.openjdk.org/jdk/compare/1be80a4445cf74adc9b2cd5bf262a897f9ede74f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Aug 8, 2023
@hns
Copy link
Member Author

hns commented Aug 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

Going to push as commit 52ec4bc.
Since your change was applied there have been 1341 commits pushed to the master branch:

  • 9cf12bb: 8313922: Remove unused WorkerPolicy::_debug_perturbation
  • 6e3cc13: 8312467: relax the builddir check in make/autoconf/basic.m4
  • 77e5739: 8310118: Resource files should be moved to appropriate directories
  • 96304f3: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 3fb4805: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects
  • 0a42c44: 8313954: Add gc logging to vmTestbase/vm/gc/containers/Combination05
  • 735b16a: 8313752: InstanceKlassFlags::print_on doesn't print the flag names
  • d3b578f: 8313345: SuperWord fails due to CMove without matching Bool pack
  • 31a307f: 8306441: Two phase segmented heap dump
  • 515add8: 8313206: PKCS11 tests silently skip execution
  • ... and 1331 more: https://git.openjdk.org/jdk/compare/1be80a4445cf74adc9b2cd5bf262a897f9ede74f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2023
@openjdk openjdk bot closed this Aug 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@hns Pushed as commit 52ec4bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants