8307067: remove broken EnableThreadSMRExtraValidityChecks option #13704

dcubed-ojdk · 2023-04-27T22:17:30Z

A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8307067: remove broken EnableThreadSMRExtraValidityChecks option

Reviewers

Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to bfb24496
David Holmes (@dholmes-ora - Reviewer)
Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to bfb24496
Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13704/head:pull/13704
$ git checkout pull/13704

Update a local copy of the PR:
$ git checkout pull/13704
$ git pull https://git.openjdk.org/jdk.git pull/13704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13704

View PR using the GUI difftool:
$ git pr show -t 13704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13704.diff

Webrev

Link to Webrev Comment

dcubed-ojdk · 2023-04-27T22:17:45Z

/label add hotspot-runtime
/label add serviceability

bridgekeeper · 2023-04-27T22:19:02Z

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-27T22:21:04Z

@dcubed-ojdk
The hotspot-runtime label was successfully added.

openjdk · 2023-04-27T22:22:09Z

@dcubed-ojdk
The serviceability label was successfully added.

mlbridge · 2023-04-28T19:40:54Z

Webrevs

coleenp

Yes, this looks good and also trivial.

openjdk · 2023-05-01T13:45:42Z

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307067: remove broken EnableThreadSMRExtraValidityChecks option

Reviewed-by: coleenp, dholmes, sspitsyn, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

e54051a: 8307935: Class space argument processing can be simplified
46e3d24: 8155191: Specify that SecureRandom.nextBytes(byte[]) throws NullPointerException when byte array is null
3bf3876: 8307297: Move some DnD tests to open
d8afc7b: 8300204: Sealed-class hierarchy graph missing nodes
38838b3: 8307480: Improve SA "transported core" documentation for windows
9842ff4: 8306607: Apply 80-column output to javac supported version output
d809823: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop()
4441a23: 6714245: [Col] Collator - Faster Comparison for identical strings.
a284920: 8168469: Memory leak in JceSecurity
7455bb2: 8308015: Syntax of "import static" is incorrect in com.sun.source.tree.ImportTree.java
... and 19 more: https://git.openjdk.org/jdk/compare/54c06d2d915e57d822136b403ea7a7675325d6fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dholmes-ora

One minor nit but otherwise good. Thanks.

dholmes-ora · 2023-05-02T08:04:52Z

src/hotspot/share/runtime/threadSMR.cpp

-    if (EnableThreadSMRExtraValidityChecks && !includes(java_thread)) {
-      // Not on the JavaThreads list so it is not alive.
+    // java_thread is not the current JavaThread so we have to verify it
+    // against the ThreadsList:


Colon at the end of the comment seems odd

Nice catch! Fixed.

dcubed-ojdk · 2023-05-02T20:29:18Z

@coleenp, @dholmes-ora and @sspitsyn - thanks for the reviews!

I suppose there isn't any way to give @robehn credit for his reviews when this
fix was part of #13519.

dcubed-ojdk · 2023-05-02T20:56:21Z

This fix was tested with Mach5 Tier[1-8] when it was part of:
#13519

and is also being tested with Mach5 Tier[1-8] combined with
the fix from JDK-8307068 and what remains in JDK-8305670.

robehn

Looks good, thanks!

dcubed-ojdk · 2023-05-04T18:43:27Z

@robehn - Thanks for the re-review!

dcubed-ojdk · 2023-05-13T14:31:09Z

@dholmes-ora - Thanks for the re-review!

dcubed-ojdk · 2023-05-13T14:38:50Z

/integrate

openjdk · 2023-05-13T14:40:05Z

Going to push as commit 5e26e64.
Since your change was applied there have been 29 commits pushed to the master branch:

e54051a: 8307935: Class space argument processing can be simplified
46e3d24: 8155191: Specify that SecureRandom.nextBytes(byte[]) throws NullPointerException when byte array is null
3bf3876: 8307297: Move some DnD tests to open
d8afc7b: 8300204: Sealed-class hierarchy graph missing nodes
38838b3: 8307480: Improve SA "transported core" documentation for windows
9842ff4: 8306607: Apply 80-column output to javac supported version output
d809823: 8306471: Add virtual threads support to JDWP ThreadReference.Stop and JDI ThreadReference.stop()
4441a23: 6714245: [Col] Collator - Faster Comparison for identical strings.
a284920: 8168469: Memory leak in JceSecurity
7455bb2: 8308015: Syntax of "import static" is incorrect in com.sun.source.tree.ImportTree.java
... and 19 more: https://git.openjdk.org/jdk/compare/54c06d2d915e57d822136b403ea7a7675325d6fb...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-13T14:40:18Z

@dcubed-ojdk Pushed as commit 5e26e64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8307067: remove broken EnableThreadSMRExtraValidityChecks option

bfb2449

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 27, 2023

openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 27, 2023

dcubed-ojdk marked this pull request as ready for review April 28, 2023 19:23

openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023

openjdk bot mentioned this pull request Apr 28, 2023

8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList #13723

Closed

3 tasks

dcubed-ojdk mentioned this pull request Apr 28, 2023

8305670: Performance regression in LockSupport.unpark with lots of idle threads #13519

Closed

3 tasks

coleenp approved these changes May 1, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 1, 2023

dholmes-ora approved these changes May 2, 2023

View reviewed changes

sspitsyn approved these changes May 2, 2023

View reviewed changes

dholmes CR - change ':' to '.'.

59f7a22

robehn approved these changes May 4, 2023

View reviewed changes

Merge branch 'master' into JDK-8307067

a3357b9

dholmes-ora approved these changes May 11, 2023

View reviewed changes

Merge branch 'master' into JDK-8307067

eae8275

openjdk bot added the integrated Pull request has been integrated label May 13, 2023

openjdk bot closed this May 13, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2023

dcubed-ojdk deleted the JDK-8307067 branch June 9, 2023 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8307067: remove broken EnableThreadSMRExtraValidityChecks option #13704

8307067: remove broken EnableThreadSMRExtraValidityChecks option #13704

dcubed-ojdk commented Apr 27, 2023 •

edited by openjdk bot

Loading

dcubed-ojdk commented Apr 27, 2023 •

edited

Loading

bridgekeeper bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

mlbridge bot commented Apr 28, 2023 •

edited

Loading

coleenp left a comment

openjdk bot commented May 1, 2023 •

edited

Loading

dholmes-ora left a comment

dholmes-ora May 2, 2023

dcubed-ojdk May 2, 2023

dcubed-ojdk commented May 2, 2023

dcubed-ojdk commented May 2, 2023

robehn left a comment

dcubed-ojdk commented May 4, 2023

dcubed-ojdk commented May 13, 2023

dcubed-ojdk commented May 13, 2023

openjdk bot commented May 13, 2023

openjdk bot commented May 13, 2023

8307067: remove broken EnableThreadSMRExtraValidityChecks option #13704

8307067: remove broken EnableThreadSMRExtraValidityChecks option #13704

Conversation

dcubed-ojdk commented Apr 27, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

dcubed-ojdk commented Apr 27, 2023 • edited Loading

bridgekeeper bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

mlbridge bot commented Apr 28, 2023 • edited Loading

Webrevs

coleenp left a comment

Choose a reason for hiding this comment

openjdk bot commented May 1, 2023 • edited Loading

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora May 2, 2023

Choose a reason for hiding this comment

dcubed-ojdk May 2, 2023

Choose a reason for hiding this comment

dcubed-ojdk commented May 2, 2023

dcubed-ojdk commented May 2, 2023

robehn left a comment

Choose a reason for hiding this comment

dcubed-ojdk commented May 4, 2023

dcubed-ojdk commented May 13, 2023

dcubed-ojdk commented May 13, 2023

openjdk bot commented May 13, 2023

openjdk bot commented May 13, 2023

dcubed-ojdk commented Apr 27, 2023 •

edited by openjdk bot

Loading

dcubed-ojdk commented Apr 27, 2023 •

edited

Loading

mlbridge bot commented Apr 28, 2023 •

edited

Loading

openjdk bot commented May 1, 2023 •

edited

Loading