8307005: Make CardTableBarrierSet::initialize non-virtual

[albertnetymk]

Trivial removing virtual specifier.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307005: Make CardTableBarrierSet::initialize non-virtual

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13713/head:pull/13713
$ git checkout pull/13713

Update a local copy of the PR:
$ git checkout pull/13713
$ git pull https://git.openjdk.org/jdk.git pull/13713/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13713

View PR using the GUI difftool:
$ git pr show -t 13713

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13713.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cab04762)

[dholmes-ora]

Looks fine and trivial. Thanks.

Odd this went to the hotspot-dev list instead of hotspot-gc-dev.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307005: Make CardTableBarrierSet::initialize non-virtual

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 86f97fe: 8305919: java/lang/Thread/virtual/HoldsLock.java#id0 failed, ThreadInfo.getLockInfo() return null
• 2179a8f: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
• 1227a27: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions
• 35e75c1: 8301455: comments in TestTypeAnnotations still refer to resolved JDK-8068737
• 561ec9c: 8300818: Reduce complexity of padding with DateTimeFormatter
• ae5f678: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread
• c7e1df8: 8304760: Add 2 Microsoft TLS roots
• 6acf032: 8306678: Replace use of os.version with an internal Version record
• f00a748: 8304915: Create jdk.internal.util.Architecture enum and apply
• 7d07d19: 8305201: Improve error message for GroupLayouts that are too large on SysV
• ... and 49 more: https://git.openjdk.org/jdk/compare/1be80a4445cf74adc9b2cd5bf262a897f9ede74f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 891530f.
Since your change was applied there have been 77 commits pushed to the master branch:

• e0774be: 8306997: C2: "malformed control flow" assert due to missing safepoint on backedge with a switch
• 462b1df: 8307106: Allow concurrent GCs to walk CLDG without ClassLoaderDataGraph_lock
• c8f3756: 8306729: Add nominal descriptors of modules and packages to Constants API
• 0b5b642: 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
• 418a825: 8306466: Open source more AWT Drag & Drop related tests
• 74667e3: 8303919: Instant.ofEpochMilli says it can throw an exception that it can't
• 76991c8: 8282232: [Win] GetMousePositionWithPopup test fails due to wrong mouse position
• 05b9b58: 8302496: Runtime.exit incorrectly says it never throws an exception
• 8a70664: 8293117: Add atomic bitset functions
• 8c106b0: 8303784: no-@target annotations should be applicable to type parameter declarations
• ... and 67 more: https://git.openjdk.org/jdk/compare/1be80a4445cf74adc9b2cd5bf262a897f9ede74f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 891530f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.