8307103: Two TestMetaspaceAllocationMT tests fail after JDK-8306696#13714
8307103: Two TestMetaspaceAllocationMT tests fail after JDK-8306696#13714DamonFool wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
|
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
dholmes-ora
left a comment
There was a problem hiding this comment.
Looks good! Thanks for fixing @DamonFool !
I'd consider this a trivial fix.
|
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks @dholmes-ora for the quick review. |
|
Going to push as commit 452cb84. |
|
@DamonFool Pushed as commit 452cb84. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Thanks @DamonFool ! Sorry for the trouble. Cheers, Thomas |
This is because
Settings.settings().reclaimPolicyhad been removed in JDK-8306696.So we can just remove the prints in the tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13714/head:pull/13714$ git checkout pull/13714Update a local copy of the PR:
$ git checkout pull/13714$ git pull https://git.openjdk.org/jdk.git pull/13714/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13714View PR using the GUI difftool:
$ git pr show -t 13714Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13714.diff
Webrev
Link to Webrev Comment