8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails

[mrserb]

These tests draw some specific pattern to the VolatileImage and to the BufferedImage, and then compare pixels.

The test uses the getSnapshot() method to get the pixels from VolatileImage, and this method produces some interpolation "artifacts" if the fractional scale is used in the system(like 125%).

The solution is to use some predefined scale to pass the tests, to reproduce initial bug scale=1 is enough.
One test fails because of the bug in the XRender pipeline.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux aarch64	Linux arm	Linux ppc64le	Linux s390x	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (6/6 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)					✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1372/head:pull/1372
$ git checkout pull/1372

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

/label add 2d

[mrserb]

/label remove awt

[openjdk]

@mrserb
The 2d label was successfully added.

[openjdk]

@mrserb
The awt label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (51f4ae3)

[shipilev]

I have a drive-by question: why do some tests run with -Dsun.java2d.uiScale=3, and some are not?

[mrserb]

I have a drive-by question: why do some tests run with -Dsun.java2d.uiScale=3, and some are not?

The tests which use odd scale=3 are more tolerant to the artifacts caused by the interpolation when a bigger image is drawn to the smaller image.

[shipilev]

Thanks for the explanation. Looks fine to me then.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• f6d6a07: 8256938: Improve remembered set sampling task scheduling
• b823ad9: 8257072: ZGC: Rename roots iterators
• 973255c: 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails
• a8e3eab: 8245026: PsAdaptiveSizePolicy::_old_gen_policy_is_ready is unused
• b1d1499: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
• 20020d1: 8254360: Re-examine use of CodeBuffer::verify_section_allocation
• e56a8df: 8257042: [aix] Disable os.release_one_mapping_multi_commits_vm gtest
• 9d7121c: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2
• 434b98f: 8257077: ZGC: Remove ZWorkers::run_serial()
• f3fc0e0: 8257079: ZGC: Fold ZMark::prepare_mark() into ZMark::start()
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/1aa90ac6295e2cdda078eabf0a32e109c2e6c38f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 103 commits pushed to the master branch:

• 65137ff: 8253753: Enable default constructor warning in client modules
• f6bfbb2: 8257208: Fix typo in doc/building.md
• b4cba15: 8170432: Class java.util.UUID & @OverRide
• 5be4de8: 8245058: improve presentation of annotations for modules and packages
• d51e2ab: 8256986: [PPC64] C2 crashes when accessing nonexisting jvms of CallLeafDirectNode
• 644271e: 8248566: Make API docs more usable on mobile browsers
• 53d1444: 8244535: JavaDoc search is overly strict with letter case
• 78fdb65: 8254893: Fix display of search tag results without holder information
• 20525d2: 8257149: Improve G1 Service thread task scheduling to guarantee task delay
• f2f3ba9: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript
• ... and 93 more: https://git.openjdk.java.net/jdk/compare/1aa90ac6295e2cdda078eabf0a32e109c2e6c38f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1241f80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.