New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails #1372
Conversation
|
/label add 2d |
/label remove awt |
@mrserb |
@mrserb |
I have a drive-by question: why do some tests run with -Dsun.java2d.uiScale=3
, and some are not?
The tests which use odd scale=3 are more tolerant to the artifacts caused by the interpolation when a bigger image is drawn to the smaller image. |
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 79 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@mrserb Since your change was applied there have been 103 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1241f80. |
These tests draw some specific pattern to the VolatileImage and to the BufferedImage, and then compare pixels.
The test uses the getSnapshot() method to get the pixels from VolatileImage, and this method produces some interpolation "artifacts" if the fractional scale is used in the system(like 125%).
The solution is to use some predefined scale to pass the tests, to reproduce initial bug scale=1 is enough.
One test fails because of the bug in the XRender pipeline.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1372/head:pull/1372
$ git checkout pull/1372