Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails #1372

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 22, 2020

These tests draw some specific pattern to the VolatileImage and to the BufferedImage, and then compare pixels.

The test uses the getSnapshot() method to get the pixels from VolatileImage, and this method produces some interpolation "artifacts" if the fractional scale is used in the system(like 125%).

The solution is to use some predefined scale to pass the tests, to reproduce initial bug scale=1 is enough.
One test fails because of the bug in the XRender pipeline.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (6/6 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1372/head:pull/1372
$ git checkout pull/1372

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 22, 2020
@mrserb
Copy link
Member Author

mrserb commented Nov 22, 2020

/label add 2d

@mrserb
Copy link
Member Author

mrserb commented Nov 22, 2020

/label remove awt

@openjdk
Copy link

openjdk bot commented Nov 22, 2020

@mrserb
The 2d label was successfully added.

@openjdk openjdk bot added 2d and removed awt labels Nov 22, 2020
@openjdk
Copy link

openjdk bot commented Nov 22, 2020

@mrserb
The awt label was successfully removed.

@mrserb mrserb changed the title 8056077: Test java/awt/image/DrawImage/IncorrectAlphaSurface2SW.java fails 8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails Nov 22, 2020
@mrserb mrserb marked this pull request as ready for review Nov 22, 2020
@openjdk openjdk bot added the rfr label Nov 22, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2020

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

I have a drive-by question: why do some tests run with -Dsun.java2d.uiScale=3, and some are not?

@mrserb
Copy link
Member Author

mrserb commented Nov 24, 2020

I have a drive-by question: why do some tests run with -Dsun.java2d.uiScale=3, and some are not?

The tests which use odd scale=3 are more tolerant to the artifacts caused by the interpolation when a bigger image is drawn to the smaller image.

Copy link
Contributor

@shipilev shipilev left a comment

Thanks for the explanation. Looks fine to me then.

@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196086: java/awt/image/DrawImage/IncorrectSourceOffset.java fails

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 26, 2020
@mrserb
Copy link
Member Author

mrserb commented Nov 28, 2020

/integrate

@openjdk openjdk bot closed this Nov 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 28, 2020
@openjdk
Copy link

openjdk bot commented Nov 28, 2020

@mrserb Since your change was applied there have been 103 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 1241f80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8056077 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
2 participants