8307088: Allow the jdbc.drivers system property to be searchable

[LanceAndersen]

Hi all,

Please review this trivial change which allows the jdbc.drivers system property to be searchable.

Best.
Lance

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307088: Allow the jdbc.drivers system property to be searchable

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13724/head:pull/13724
$ git checkout pull/13724

Update a local copy of the PR:
$ git checkout pull/13724
$ git pull https://git.openjdk.org/jdk.git pull/13724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13724

View PR using the GUI difftool:
$ git pr show -t 13724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13724.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@LanceAndersen The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e3666952)

[openjdk]

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307088: Allow the jdbc.drivers system property to be searchable

Reviewed-by: naoto, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 6d6f726: 8307078: Opensource and clean up five more AWT Focus related tests
• 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
• 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
• f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
• 82ccfe3: 8305975: Add TWCA Global Root CA
• a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
• e119658: 8303475: potential null pointer dereference in filemap.cpp
• cf799ba: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock
• 485a069: 8306432: Open source several AWT Text Component related tests
• 169a7c2: 8306640: Open source several AWT TextArea related tests
• ... and 40 more: https://git.openjdk.org/jdk/compare/2e340e855b760e381793107f2a4d74095bd40199...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[eirbjo]

Somewhat unrelated perhaps, but I found the example value given for jdbc.drivers in DriverManager javadocs to be a bit funky.

jdbc.drivers=foo.bah.Driver:wombat.sql.Driver:bad.taste.ourDriver

I know, I know, coming up with examples is hard, but perhaps we could find something more boring, realistic, package- and database-looking example drivers?

Something like:

jdbc.drivers=com.company.jdbc.Driver:org.somedb.Driver:org.otherdb.JbdcDriver

I know this is very subjective, and not really related to the issue. But I thought I'd mention it now that this code is updated.

[LanceAndersen]

Somewhat unrelated perhaps, but I found the example value given for jdbc.drivers in DriverManager javadocs to be a bit funky.

jdbc.drivers=foo.bah.Driver:wombat.sql.Driver:bad.taste.ourDriver

I know, I know, coming up with examples is hard, but perhaps we could find something more boring, realistic, package- and database-looking example drivers?

Something like:

jdbc.drivers=com.company.jdbc.Driver:org.somedb.Driver:org.otherdb.JbdcDriver

I know this is very subjective, and not really related to the issue. But I thought I'd mention it now that this code is updated.

This dates back to the first release of JDBC in JDK 1.1. I will add it to my todo list as there is more work to be done in the javadocs, but will leave it as its for now. Even with when its is updated, wombat.sql.driver will stay to honor Rick Cattell and Graham Hamilton :-)

[LanceAndersen]

/integrate

[openjdk]

Going to push as commit bb7608b.
Since your change was applied there have been 58 commits pushed to the master branch:

• a2d3fc8: 8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names
• d43a5a2: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
• 1f68924: 8306955: Open source several JComboBox jtreg tests
• b8de394: 8307080: Open source some more JComboBox jtreg tests
• 4818c79: 8307110: zero build broken after JDK-8304265
• da9efee: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException
• 05af487: 8306681: Open source more AWT DnD related tests
• ec5c792: 8306133: Open source few AWT Drag & Drop related tests
• 6d6f726: 8307078: Opensource and clean up five more AWT Focus related tests
• 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
• ... and 48 more: https://git.openjdk.org/jdk/compare/2e340e855b760e381793107f2a4d74095bd40199...master

Your commit was automatically rebased without conflicts.

[openjdk]

@LanceAndersen Pushed as commit bb7608b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.