8306871: Open source more AWT Drag & Drop tests #13725

DamonGuy · 2023-04-28T18:34:36Z

This PR open sources more AWT DnD & Event related tests

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8306871: Open source more AWT Drag & Drop tests

Reviewers

Phil Race (@prrace - Reviewer) ⚠️ Review applies to 9999d9cc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13725/head:pull/13725
$ git checkout pull/13725

Update a local copy of the PR:
$ git checkout pull/13725
$ git pull https://git.openjdk.org/jdk.git pull/13725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13725

View PR using the GUI difftool:
$ git pr show -t 13725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13725.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-04-28T18:35:23Z

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-28T18:37:40Z

@DamonGuy The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-28T18:52:59Z

Webrevs

01: Full - Incremental (97383c7f)
00: Full (9999d9cc)

prrace · 2023-04-28T22:07:28Z

test/jdk/java/awt/event/KeyEvent/AltGraphModifier.java

+  @test
+  @bug 4343344
+  @summary Tests key modifiers when ALT_GRAPH key is pressed by Robot.
+           This test is for UNIX only.


I think this comment is confusing and should be removed since
(1) the test is only being excluded on mac which is actually Unix
(2) it is being run on Windows which most definitely isn't Unix.

Section about "UNIX ONLY" removed.

prrace

Fix the comment before integration

openjdk · 2023-04-28T22:10:12Z

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306871: Open source more AWT Drag & Drop tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

fc76687: 8306836: Remove pinned tag for G1 heap regions
ccf91f8: 8306933: C2: "assert(false) failed: infinite loop" failure
e9807a4: 8306042: C2: failed: Missed optimization opportunity in PhaseCCP (adding LShift->Cast->Add notification)
fcb280a: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity
891530f: 8307005: Make CardTableBarrierSet::initialize non-virtual
e0774be: 8306997: C2: "malformed control flow" assert due to missing safepoint on backedge with a switch
462b1df: 8307106: Allow concurrent GCs to walk CLDG without ClassLoaderDataGraph_lock
c8f3756: 8306729: Add nominal descriptors of modules and packages to Constants API
0b5b642: 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
418a825: 8306466: Open source more AWT Drag & Drop related tests
... and 45 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

turbanoff · 2023-05-02T16:09:27Z

test/jdk/java/awt/event/KeyEvent/KeyTyped/CancelKeyTyped.java

+            }
+
+            protected void printKey(KeyEvent evt) {
+                switch(evt.getID()) {


Suggested change

switch(evt.getID()) {

switch (evt.getID()) {

turbanoff · 2023-05-02T16:09:52Z

test/jdk/java/awt/event/KeyEvent/AltGraphModifier.java

+                        for (int i=0; i < modifierKeys.length; i++) {
+                            if (modifierPress[i] == true) {
+                                if ((kp.getModifiersEx() & inputMasks[i]) == inputMasks[i]) {
+                                }  else {


Suggested change

} else {

} else {

turbanoff · 2023-05-02T16:10:16Z

test/jdk/java/awt/event/InputEvent/MouseModsTest.java

+    }
+
+    static int getKeycode(int ctrl) {
+        switch(ctrl) {


Suggested change

switch(ctrl) {

switch (ctrl) {

turbanoff · 2023-05-02T16:10:27Z

test/jdk/java/awt/event/InputEvent/MouseModsTest.java

+    }
+
+    static int getKeyModifier(int ctrl) {
+        switch(ctrl) {


Suggested change

switch(ctrl) {

switch (ctrl) {

turbanoff · 2023-05-02T16:10:35Z

test/jdk/java/awt/event/InputEvent/MouseModsTest.java

+    }
+
+    static int getMouseModifier(int btn) {
+        switch(btn) {


Suggested change

switch(btn) {

switch (btn) {

DamonGuy · 2023-05-05T16:27:28Z

/integrate

openjdk · 2023-05-05T16:28:12Z

Going to push as commit b5a4827.
Since your change was applied there have been 95 commits pushed to the master branch:

47422be: 8307375: Alignment check on layouts used as sequence element is not correct
3968ab5: 8307395: Add missing STS to Shenandoah
12d6ec6: 8307236: Rendezvous GC threads under STS for monitor deflation
6fe959c: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at
3f6a354: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
746f8d1: 8305714: Add an extra test for JDK-8292755
1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
948f3b3: 8301493: Replace NULL with nullptr in cpu/aarch64
... and 85 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-05T16:28:23Z

@DamonGuy Pushed as commit b5a4827.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Initial test add

9999d9c

openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Apr 28, 2023

prrace reviewed Apr 28, 2023

View reviewed changes

prrace approved these changes Apr 28, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2023

turbanoff reviewed May 2, 2023

View reviewed changes

Fix syntax. Edit comment

97383c7

openjdk bot added the integrated Pull request has been integrated label May 5, 2023

openjdk bot closed this May 5, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8306871: Open source more AWT Drag & Drop tests #13725

8306871: Open source more AWT Drag & Drop tests #13725

DamonGuy commented Apr 28, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 28, 2023

openjdk bot commented Apr 28, 2023

mlbridge bot commented Apr 28, 2023 •

edited

Loading

prrace Apr 28, 2023

DamonGuy May 3, 2023

prrace left a comment

openjdk bot commented Apr 28, 2023 •

edited

Loading

turbanoff May 2, 2023

DamonGuy May 3, 2023

turbanoff May 2, 2023

DamonGuy May 3, 2023

turbanoff May 2, 2023

DamonGuy May 3, 2023

turbanoff May 2, 2023

DamonGuy May 3, 2023

turbanoff May 2, 2023

DamonGuy May 3, 2023

DamonGuy commented May 5, 2023

openjdk bot commented May 5, 2023

openjdk bot commented May 5, 2023

8306871: Open source more AWT Drag & Drop tests #13725

8306871: Open source more AWT Drag & Drop tests #13725

Conversation

DamonGuy commented Apr 28, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 28, 2023

openjdk bot commented Apr 28, 2023

mlbridge bot commented Apr 28, 2023 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DamonGuy commented May 5, 2023

openjdk bot commented May 5, 2023

openjdk bot commented May 5, 2023

DamonGuy commented Apr 28, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 28, 2023 •

edited

Loading

openjdk bot commented Apr 28, 2023 •

edited

Loading