Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304760: Add 2 Microsoft TLS roots #13726

Closed
wants to merge 5 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Apr 28, 2023

This PR is to add two new TLS root certificates from Microsoft. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.

The release-note is at JDK-8307129


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13726/head:pull/13726
$ git checkout pull/13726

Update a local copy of the PR:
$ git checkout pull/13726
$ git pull https://git.openjdk.org/jdk.git pull/13726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13726

View PR using the GUI difftool:
$ git pr show -t 13726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13726.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 28, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 1, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304760: Add 2 Microsoft TLS roots

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 6acf032: 8306678: Replace use of os.version with an internal Version record
  • f00a748: 8304915: Create jdk.internal.util.Architecture enum and apply
  • 7d07d19: 8305201: Improve error message for GroupLayouts that are too large on SysV
  • 67dd841: 8305093: Linker cache should not take layout names into account
  • d437c61: 8305672: Surprising definite assignment error after JDK-8043179
  • b39a9bf: 8301703: java.base jdk.internal.foreign.abi.BindingSpecializer uses ASM to generate classes
  • 1de1a38: 8303002: Reject packed structs from linker
  • 316d303: 8306851: Move Method access flags
  • a6b4f25: 8306825: Monitor deflation might be accidentally disabled by zero intervals
  • 2d7c507: 8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E
  • ... and 15 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 1, 2023
@rhalade
Copy link
Member Author

rhalade commented May 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 1, 2023

Going to push as commit c7e1df8.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 6acf032: 8306678: Replace use of os.version with an internal Version record
  • f00a748: 8304915: Create jdk.internal.util.Architecture enum and apply
  • 7d07d19: 8305201: Improve error message for GroupLayouts that are too large on SysV
  • 67dd841: 8305093: Linker cache should not take layout names into account
  • d437c61: 8305672: Surprising definite assignment error after JDK-8043179
  • b39a9bf: 8301703: java.base jdk.internal.foreign.abi.BindingSpecializer uses ASM to generate classes
  • 1de1a38: 8303002: Reject packed structs from linker
  • 316d303: 8306851: Move Method access flags
  • a6b4f25: 8306825: Monitor deflation might be accidentally disabled by zero intervals
  • 2d7c507: 8305778: javax/swing/JTableHeader/6884066/bug6884066.java: Unexpected header's value; index = 4 value = E
  • ... and 15 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 1, 2023
@openjdk openjdk bot closed this May 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 1, 2023
@openjdk
Copy link

openjdk bot commented May 1, 2023

@rhalade Pushed as commit c7e1df8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8303393-microsofttls branch May 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants