8305963: Typo in java.security.Security.getProperty #13729

driverkt · 2023-04-28T20:55:33Z

Fix type-o and update returns message.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8305963: Typo in java.security.Security.getProperty

Reviewers

Sean Coffey (@coffeys - Reviewer) ⚠️ Review applies to e7046330
Bradford Wetmore (@bradfordwetmore - Reviewer) ⚠️ Review applies to e7046330

Contributors

Sean Coffey <coffeys@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13729/head:pull/13729
$ git checkout pull/13729

Update a local copy of the PR:
$ git checkout pull/13729
$ git pull https://git.openjdk.org/jdk.git pull/13729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13729

View PR using the GUI difftool:
$ git pr show -t 13729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13729.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-04-28T20:56:28Z

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-28T20:58:45Z

@driverkt Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk · 2023-04-28T20:59:28Z

@driverkt The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

driverkt · 2023-04-28T21:00:03Z

/contributor add @coffeys

openjdk · 2023-04-28T21:01:07Z

@driverkt
Contributor Sean Coffey <coffeys@openjdk.org> successfully added.

mlbridge · 2023-04-28T21:15:56Z

Webrevs

coffeys

Looks good

openjdk · 2023-04-28T21:24:58Z

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305963: Typo in java.security.Security.getProperty

Co-authored-by: Sean Coffey <coffeys@openjdk.org>
Reviewed-by: coffeys, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @bradfordwetmore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

driverkt · 2023-04-30T06:43:58Z

/integrate

openjdk · 2023-04-30T06:45:02Z

@driverkt
Your change (at version e704633) is now ready to be sponsored by a Committer.

seanjmullan · 2023-05-01T15:27:18Z

src/java.base/share/classes/java/security/Security.java

@@ -702,14 +702,15 @@ static Object[] getImpl(String algorithm, String type, Provider provider,
     *
     * @param key the key of the property being retrieved.
     *
-     * @return the value of the security property corresponding to key.
+     * @return the string value of the security property, or null if there


I don't think saying "string" is necessary - since this method can only return a String.
Put "null" in code syntax: {@code null}.

valeriepeng · 2023-05-01T21:21:15Z

src/java.base/share/classes/java/security/Security.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2022, 2023, Oracle and/or its affiliates. All rights reserved.


Seems incorrect to have 3 copyright years.

Correct, only the beginning and current year. 1996, 2023, Oracle...

bradfordwetmore

I agree with Sean/Valerie's comments. Otherwise, LGTM.

openjdk · 2023-05-03T20:33:46Z

⚠️ @driverkt This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk · 2023-05-03T20:37:39Z

@driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

driverkt · 2023-05-03T20:38:19Z

@seanjmullan @valeriepeng : see 57e7f99

driverkt · 2023-05-03T20:38:59Z

/integrate

openjdk · 2023-05-03T20:40:22Z

@driverkt
Your change (at version 57e7f99) is now ready to be sponsored by a Committer.

bradfordwetmore · 2023-05-03T20:46:12Z

/sponsor

openjdk · 2023-05-03T20:47:32Z

Going to push as commit db8b3cd.
Since your change was applied there has been 1 commit pushed to the master branch:

dcb2f3f: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-03T20:47:50Z

@bradfordwetmore @driverkt Pushed as commit db8b3cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023

openjdk bot added the security security-dev@openjdk.org label Apr 28, 2023

coffeys approved these changes Apr 28, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 30, 2023

seanjmullan reviewed May 1, 2023

View reviewed changes

valeriepeng reviewed May 1, 2023

View reviewed changes

bradfordwetmore approved these changes May 3, 2023

View reviewed changes

driverkt added 2 commits May 3, 2023 15:28

JDK-8305963 fix type-o and update returns message

abec70a

address code review comments

57e7f99

openjdk bot removed the sponsor Pull request is ready to be sponsored label May 3, 2023

driverkt force-pushed the JDK-8305963 branch from 5241d39 to 57e7f99 Compare May 3, 2023 20:36

openjdk bot added the sponsor Pull request is ready to be sponsored label May 3, 2023

openjdk bot added the integrated Pull request has been integrated label May 3, 2023

openjdk bot closed this May 3, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 3, 2023

driverkt deleted the JDK-8305963 branch May 5, 2023 20:18

8305963: Typo in java.security.Security.getProperty #13729

8305963: Typo in java.security.Security.getProperty #13729

Uh oh!

Conversation

driverkt commented Apr 28, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Contributors

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Apr 28, 2023

Uh oh!

openjdk bot commented Apr 28, 2023

Uh oh!

openjdk bot commented Apr 28, 2023

Uh oh!

driverkt commented Apr 28, 2023

Uh oh!

openjdk bot commented Apr 28, 2023

Uh oh!

mlbridge bot commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

coffeys left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

driverkt commented Apr 30, 2023

Uh oh!

openjdk bot commented Apr 30, 2023

Uh oh!

seanjmullan May 1, 2023

Choose a reason for hiding this comment

Uh oh!

valeriepeng May 1, 2023

Choose a reason for hiding this comment

Uh oh!

bradfordwetmore May 2, 2023

Choose a reason for hiding this comment

Uh oh!

bradfordwetmore left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented May 3, 2023

Uh oh!

openjdk bot commented May 3, 2023

Uh oh!

driverkt commented May 3, 2023

Uh oh!

driverkt commented May 3, 2023

Uh oh!

openjdk bot commented May 3, 2023

Uh oh!

bradfordwetmore commented May 3, 2023

Uh oh!

openjdk bot commented May 3, 2023

Uh oh!

openjdk bot commented May 3, 2023

Uh oh!

Uh oh!

driverkt commented Apr 28, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 28, 2023 •

edited

Loading

openjdk bot commented Apr 28, 2023 •

edited

Loading