Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8307080: Open source some more JComboBox jtreg tests #13731

Closed
wants to merge 2 commits into from
Closed

8307080: Open source some more JComboBox jtreg tests #13731

wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 28, 2023 •
edited by openjdk bot
Loading

Open source another 5 JComboBox tests.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307080: Open source some more JComboBox jtreg tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13731/head:pull/13731
$ git checkout pull/13731

Update a local copy of the PR:
$ git checkout pull/13731
$ git pull https://git.openjdk.org/jdk.git pull/13731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13731

View PR using the GUI difftool:
$ git pr show -t 13731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13731.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2023

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8307080 8307080: Open source some more JComboBox jtreg tests Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 28, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307080: Open source some more JComboBox jtreg tests

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 4818c79: 8307110: zero build broken after JDK-8304265
  • da9efee: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException
  • 05af487: 8306681: Open source more AWT DnD related tests
  • ec5c792: 8306133: Open source few AWT Drag & Drop related tests
  • 6d6f726: 8307078: Opensource and clean up five more AWT Focus related tests
  • 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
  • f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
  • 82ccfe3: 8305975: Add TWCA Global Root CA
  • a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
  • ... and 15 more: https://git.openjdk.org/jdk/compare/b827ce8334c568d72990985ff6077db8334e2754...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2023
@prrace
Copy link
Contributor Author

prrace commented Apr 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

Going to push as commit b8de394.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 4818c79: 8307110: zero build broken after JDK-8304265
  • da9efee: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException
  • 05af487: 8306681: Open source more AWT DnD related tests
  • ec5c792: 8306133: Open source few AWT Drag & Drop related tests
  • 6d6f726: 8307078: Opensource and clean up five more AWT Focus related tests
  • 89711f3: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 9ff5550: 8307077: Convert CRLF to LF in java.xml.crypto
  • f83e730: 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
  • 82ccfe3: 8305975: Add TWCA Global Root CA
  • a177152: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
  • ... and 15 more: https://git.openjdk.org/jdk/compare/b827ce8334c568d72990985ff6077db8334e2754...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2023
@openjdk openjdk bot closed this Apr 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@prrace Pushed as commit b8de394.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mrserb
mrserb reviewed Apr 29, 2023
View reviewed changes
test/jdk/javax/swing/JComboBox/bug5029504.java
Robot robot = new Robot();
robot.delay(2000);
Point p = comboBox.getLocationOnScreen();
Dimension size = comboBox.getSize();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that JComboBox is accessed on non-EDT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrserb mrserb mrserb left review comments

@azuev-java azuev-java azuev-java approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@prrace @mrserb @azuev-java