8307143: CredentialsCache.cacheName should not be static

[wangweij]

The CC can be loaded with any file and its name is not static.

MemoryCredentialsCache is removed since it's not used anywhere. We've already supported native ccache reading directly with JNI method Credentials::acquireDefaultNativeCreds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307143: CredentialsCache.cacheName should not be static (Bug - P4)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer) ⚠️ Review applies to 33f9f599

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13737/head:pull/13737
$ git checkout pull/13737

Update a local copy of the PR:
$ git checkout pull/13737
$ git pull https://git.openjdk.org/jdk.git pull/13737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13737

View PR using the GUI difftool:
$ git pr show -t 13737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13737.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (178eb16a)
• 03: Full - Incremental (33f9f599)
• 02: Full - Incremental (f593c1ed)
• 01: Full (cdf30f69)
• 00: Full (509d28cd)

[bridgekeeper]

@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@wangweij This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[wangweij]

/open

[openjdk]

@wangweij This pull request is now open

[bridgekeeper]

@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@wangweij This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[wangweij]

/open

[openjdk]

@wangweij This pull request is now open

[bridgekeeper]

@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@wangweij this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8307143
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@wangweij This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[wangweij]

/open

[openjdk]

@wangweij This pull request is now open

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307143: CredentialsCache.cacheName should not be static

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 274c805: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1
• 140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
• a293bdf: 8330197: Make javac/diags/example release agnostic
• da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
• ddc3921: 8330103: Compiler memory statistics should keep separate records for C1 and C2
• 273df62: 8328792: Parallel: Refactor PSParallelCompact::summary_phase
• a3fecdb: 8329764: G1: Handle null references during verification first
• 60d88b7: 8330176: Typo in Linker javadoc
• 3f1d9c4: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc
• 5404b4e: 8330105: SharedRuntime::resolve* should respect interpreter-only mode
• ... and 10 more: https://git.openjdk.org/jdk/compare/0f78d017afb786345fca635862a4a70f43fff251...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[valeriepeng]

Looks good to me, just some nits.

[wangweij]

/integrate

[openjdk]

Going to push as commit 31a1f9c.
Since your change was applied there have been 20 commits pushed to the master branch:

• 274c805: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1
• 140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
• a293bdf: 8330197: Make javac/diags/example release agnostic
• da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
• ddc3921: 8330103: Compiler memory statistics should keep separate records for C1 and C2
• 273df62: 8328792: Parallel: Refactor PSParallelCompact::summary_phase
• a3fecdb: 8329764: G1: Handle null references during verification first
• 60d88b7: 8330176: Typo in Linker javadoc
• 3f1d9c4: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc
• 5404b4e: 8330105: SharedRuntime::resolve* should respect interpreter-only mode
• ... and 10 more: https://git.openjdk.org/jdk/compare/0f78d017afb786345fca635862a4a70f43fff251...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 31a1f9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.