8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

[feilongjiang]

Hi,

can I have reviews for this change that removes the remaining StoreLoad barrier for RISC-V port in CardTableBarrierSetAssembler::store_check just like JDK-8261309 did?

After the removal of CMS, this barrier is no longer needed.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13739/head:pull/13739
$ git checkout pull/13739

Update a local copy of the PR:
$ git checkout pull/13739
$ git pull https://git.openjdk.org/jdk.git pull/13739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13739

View PR using the GUI difftool:
$ git pr show -t 13739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13739.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@feilongjiang The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[feilongjiang]

/issue JDK-8307150

[openjdk]

@feilongjiang This issue is referenced in the PR title - it will now be updated.

[mlbridge]

Webrevs

• 00: Full (39e1a67d)

[shipilev]

This looks fine, thanks.

[openjdk]

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewed-by: shade, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• 418a825: 8306466: Open source more AWT Drag & Drop related tests
• 74667e3: 8303919: Instant.ofEpochMilli says it can throw an exception that it can't
• 76991c8: 8282232: [Win] GetMousePositionWithPopup test fails due to wrong mouse position
• 05b9b58: 8302496: Runtime.exit incorrectly says it never throws an exception
• 8a70664: 8293117: Add atomic bitset functions
• 8c106b0: 8303784: no-@target annotations should be applicable to type parameter declarations
• b76f320: 8307123: Fix deprecation warnings in DPrinter
• a8bf2ac: 8304888: Add dedicated VMProps for linker and fallback linker
• 75a4edc: 8301223: Replace NULL with nullptr in share/gc/g1/
• 544bd26: 8305505: NPE in javazic compiler
• ... and 23 more: https://git.openjdk.org/jdk/compare/b3dbf28bc0614bee2f7137af95389134155c9511...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[feilongjiang]

@shipilev @RealFYang -- Thanks for the review!
/integrate

[openjdk]

@feilongjiang
Your change (at version 39e1a67) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 0b5b642.
Since your change was applied there have been 33 commits pushed to the master branch:

• 418a825: 8306466: Open source more AWT Drag & Drop related tests
• 74667e3: 8303919: Instant.ofEpochMilli says it can throw an exception that it can't
• 76991c8: 8282232: [Win] GetMousePositionWithPopup test fails due to wrong mouse position
• 05b9b58: 8302496: Runtime.exit incorrectly says it never throws an exception
• 8a70664: 8293117: Add atomic bitset functions
• 8c106b0: 8303784: no-@target annotations should be applicable to type parameter declarations
• b76f320: 8307123: Fix deprecation warnings in DPrinter
• a8bf2ac: 8304888: Add dedicated VMProps for linker and fallback linker
• 75a4edc: 8301223: Replace NULL with nullptr in share/gc/g1/
• 544bd26: 8305505: NPE in javazic compiler
• ... and 23 more: https://git.openjdk.org/jdk/compare/b3dbf28bc0614bee2f7137af95389134155c9511...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @feilongjiang Pushed as commit 0b5b642.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.