Skip to content

8307133: Open source some JTable jtreg tests #13745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented May 1, 2023

Open source some Swing JTable tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13745/head:pull/13745
$ git checkout pull/13745

Update a local copy of the PR:
$ git checkout pull/13745
$ git pull https://git.openjdk.org/jdk.git pull/13745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13745

View PR using the GUI difftool:
$ git pr show -t 13745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13745.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2023

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8307133 8307133: Open source some JTable jtreg tests May 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2023
@openjdk
Copy link

openjdk bot commented May 1, 2023

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 1, 2023
@mlbridge
Copy link

mlbridge bot commented May 1, 2023

Webrevs

c.add(immediateButton, BorderLayout.SOUTH);
frame.pack();
frame.setVisible(true);
} finally {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this empty "finally" block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. Removed.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307133: Open source some JTable jtreg tests

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • 465bdd9: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • caee1be: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode
  • 3599448: 8307147: [x86] Dangling pointer warning for Assembler::_attributes
  • 64ac9a0: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output"
  • 03030d4: 8307134: Add GTS root CAs
  • 63cd0a3: 4200096: OffScreenImageSource.removeConsumer NullPointerException
  • db8b3cd: 8305963: Typo in java.security.Security.getProperty
  • dcb2f3f: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface
  • 1487477: 8305815: Update Libpng to 1.6.39
  • 705ad7d: 8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
  • ... and 54 more: https://git.openjdk.org/jdk/compare/6d6f726b74f7fcd3e7c37d50bd2476b3e921662b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2023
@prrace
Copy link
Contributor Author

prrace commented May 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 5ca0b08.
Since your change was applied there have been 72 commits pushed to the master branch:

  • 2adb3b4: 8306943: Open source several dnd AWT tests
  • dc4096c: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)
  • 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
  • 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
  • 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
  • e206d57: 8307362: Remove test com/sun/jdi/JdbLastErrorTest.java
  • 82a8e91: 8306489: Open source AWT List related tests
  • 465bdd9: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • caee1be: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode
  • ... and 62 more: https://git.openjdk.org/jdk/compare/6d6f726b74f7fcd3e7c37d50bd2476b3e921662b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@prrace Pushed as commit 5ca0b08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants