Skip to content

JDK-8307123: Fix deprecation warnings in DPrinter #13747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 1, 2023

Please review a trivial test clean to fix some deprecation warnings in the test/langtools DPrinter class.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13747/head:pull/13747
$ git checkout pull/13747

Update a local copy of the PR:
$ git checkout pull/13747
$ git pull https://git.openjdk.org/jdk.git pull/13747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13747

View PR using the GUI difftool:
$ git pr show -t 13747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13747.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2023

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2023
@openjdk
Copy link

openjdk bot commented May 1, 2023

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label May 1, 2023
@mlbridge
Copy link

mlbridge bot commented May 1, 2023

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented May 2, 2023

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307123: Fix deprecation warnings in DPrinter

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 2179a8f: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • 1227a27: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions
  • 35e75c1: 8301455: comments in TestTypeAnnotations still refer to resolved JDK-8068737
  • 561ec9c: 8300818: Reduce complexity of padding with DateTimeFormatter
  • ae5f678: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread
  • c7e1df8: 8304760: Add 2 Microsoft TLS roots
  • 6acf032: 8306678: Replace use of os.version with an internal Version record
  • f00a748: 8304915: Create jdk.internal.util.Architecture enum and apply
  • 7d07d19: 8305201: Improve error message for GroupLayouts that are too large on SysV
  • 67dd841: 8305093: Linker cache should not take layout names into account
  • ... and 21 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2023
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2023

Going to push as commit b76f320.
Since your change was applied there have been 39 commits pushed to the master branch:

  • a8bf2ac: 8304888: Add dedicated VMProps for linker and fallback linker
  • 75a4edc: 8301223: Replace NULL with nullptr in share/gc/g1/
  • 544bd26: 8305505: NPE in javazic compiler
  • ea9201f: 8306510: Print number of threads and stack sizes in error reports
  • a8d16de: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call
  • 1532a1b: 8307164: TestSegmentCopy times out (mainline)
  • 860bf9b: 8307104: [AIX] VM crashes with UseRTMLocking on Power10
  • 86f97fe: 8305919: java/lang/Thread/virtual/HoldsLock.java#id0 failed, ThreadInfo.getLockInfo() return null
  • 2179a8f: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • 1227a27: 8306028: separate ThreadStart/ThreadEnd events posting code in JVMTI VTMS transitions
  • ... and 29 more: https://git.openjdk.org/jdk/compare/9ff555083a1ba367ea157b8e1de28e62c1ce2f19...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2023
@openjdk openjdk bot closed this May 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@jonathan-gibbons Pushed as commit b76f320.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants