8306943: Open source several dnd AWT tests#13752
8306943: Open source several dnd AWT tests#13752azvegint wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Webrevs
|
| Runnable r = new Runnable() { | ||
| public void run() { | ||
| try { | ||
| if (process == null) { |
There was a problem hiding this comment.
do we need to add a sync for process and sourcePoint?
There was a problem hiding this comment.
I don't think so.
lostOwnership is called when some other client changes the contents of the clipboard.
It can be either our Child process or other programs in the system.
In first case process and sourcePoint are not null by this time.
In the second case, it will also mean a test failure because the test expects a very certain clipboard content.
I made them volatile just in case, since they are accessed from several threads.
|
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 2adb3b4.
Your commit was automatically rebased without conflicts. |
Open sourcing few more tests:
Testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13752/head:pull/13752$ git checkout pull/13752Update a local copy of the PR:
$ git checkout pull/13752$ git pull https://git.openjdk.org/jdk.git pull/13752/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13752View PR using the GUI difftool:
$ git pr show -t 13752Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13752.diff
Webrev
Link to Webrev Comment