Skip to content

8306943: Open source several dnd AWT tests#13752

Closed
azvegint wants to merge 2 commits intoopenjdk:masterfrom
azvegint:testsprint_applet_dnd_8306943
Closed

8306943: Open source several dnd AWT tests#13752
azvegint wants to merge 2 commits intoopenjdk:masterfrom
azvegint:testsprint_applet_dnd_8306943

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented May 2, 2023

Open sourcing few more tests:

java/awt/dnd/DnDAWTLockTest/DnDAWTLockTest.java
java/awt/dnd/DragGestureInvokeLaterTest/DragGestureInvokeLaterTest.java
java/awt/dnd/DragOverDropTargetPerformanceTest/DragOverDropTargetPerformanceTest.java
java/awt/dnd/DragSourceDragEventModifiersTest/DragSourceDragEventModifiersTest.java
java/awt/dnd/DragSourceGCrashTest/DragSourceGCrashTest.java

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13752/head:pull/13752
$ git checkout pull/13752

Update a local copy of the PR:
$ git checkout pull/13752
$ git pull https://git.openjdk.org/jdk.git pull/13752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13752

View PR using the GUI difftool:
$ git pr show -t 13752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13752.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

Runnable r = new Runnable() {
public void run() {
try {
if (process == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add a sync for process and sourcePoint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.

lostOwnership is called when some other client changes the contents of the clipboard.
It can be either our Child process or other programs in the system.
In first case process and sourcePoint are not null by this time.
In the second case, it will also mean a test failure because the test expects a very certain clipboard content.

I made them volatile just in case, since they are accessed from several threads.

@openjdk
Copy link

openjdk bot commented May 3, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306943: Open source several dnd AWT tests

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 465bdd9: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • caee1be: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode
  • 3599448: 8307147: [x86] Dangling pointer warning for Assembler::_attributes
  • 64ac9a0: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output"
  • 03030d4: 8307134: Add GTS root CAs
  • 63cd0a3: 4200096: OffScreenImageSource.removeConsumer NullPointerException
  • db8b3cd: 8305963: Typo in java.security.Security.getProperty
  • dcb2f3f: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface
  • 1487477: 8305815: Update Libpng to 1.6.39
  • 705ad7d: 8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
  • ... and 22 more: https://git.openjdk.org/jdk/compare/1532a1b0bd72f37b77540af51368271ef80e17d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2023
@azvegint
Copy link
Member Author

azvegint commented May 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 2adb3b4.
Since your change was applied there have been 39 commits pushed to the master branch:

  • dc4096c: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)
  • 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
  • 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
  • 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
  • e206d57: 8307362: Remove test com/sun/jdi/JdbLastErrorTest.java
  • 82a8e91: 8306489: Open source AWT List related tests
  • 465bdd9: 8307091: A few client tests intermittently throw ConcurrentModificationException
  • caee1be: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode
  • 3599448: 8307147: [x86] Dangling pointer warning for Assembler::_attributes
  • ... and 29 more: https://git.openjdk.org/jdk/compare/1532a1b0bd72f37b77540af51368271ef80e17d2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@azvegint Pushed as commit 2adb3b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants