8307295: Add warning to not create new ACC flags

[coleenp]

Please comment on or review this new comment. Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307295: Add warning to not create new ACC flags

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13757/head:pull/13757
$ git checkout pull/13757

Update a local copy of the PR:
$ git checkout pull/13757
$ git pull https://git.openjdk.org/jdk.git pull/13757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13757

View PR using the GUI difftool:
$ git pr show -t 13757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13757.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dee204b8)
• 00: Full (4139e7d2)

[dholmes-ora]

Seems a little odd to put in the to-do comments rather than just saying "Don't add any new flags" but okay.

Will those 4 flags get moved soon?

Thanks.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307295: Add warning to not create new ACC flags

Reviewed-by: dholmes, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
• 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
• cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
• 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
• e206d57: 8307362: Remove test com/sun/jdi/JdbLastErrorTest.java
• 82a8e91: 8306489: Open source AWT List related tests
• 465bdd9: 8307091: A few client tests intermittently throw ConcurrentModificationException
• caee1be: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode
• 3599448: 8307147: [x86] Dangling pointer warning for Assembler::_attributes
• 64ac9a0: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output"
• ... and 26 more: https://git.openjdk.org/jdk/compare/ea9201f42085028f6f16738214f058efb680ac09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Will those 4 flags get moved soon?

Not soon. The umbrella RFE talks about some strategies to move them incrementally, but they're kind of a lot of work since they involve generated code and compiler code.

Thanks for the review, David.

[fparain]

LGTM

[coleenp]

Thanks David and Fred.
/integrate

[openjdk]

Going to push as commit a87262e.
Since your change was applied there have been 40 commits pushed to the master branch:

• 0c6529d: 8307156: native_thread not protected by TLH
• 5ca0b08: 8307133: Open source some JTable jtreg tests
• 2adb3b4: 8306943: Open source several dnd AWT tests
• dc4096c: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)
• 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
• 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
• cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
• 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
• e206d57: 8307362: Remove test com/sun/jdi/JdbLastErrorTest.java
• 82a8e91: 8306489: Open source AWT List related tests
• ... and 30 more: https://git.openjdk.org/jdk/compare/ea9201f42085028f6f16738214f058efb680ac09...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit a87262e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.