Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307244: Remove redundant class RMIIIOPServerImpl #13758

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented May 2, 2023

Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
This class is not referenced by other classes or tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8307329 to be approved

Issues

  • JDK-8307244: Remove redundant class RMIIIOPServerImpl
  • JDK-8307329: Remove redundant class RMIIIOPServerImpl (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13758/head:pull/13758
$ git checkout pull/13758

Update a local copy of the PR:
$ git checkout pull/13758
$ git pull https://git.openjdk.org/jdk.git pull/13758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13758

View PR using the GUI difftool:
$ git pr show -t 13758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13758.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinjwalls kevinjwalls marked this pull request as ready for review May 2, 2023 17:58
@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, this transport was deprecated for some time.
But it is not clear in what release.
The fix looks good to me.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented May 2, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307244: Remove redundant class RMIIIOPServerImpl

Reviewed-by: sspitsyn, dfuchs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 540c706: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection
  • d993432: 8306930: Incorrect assert in BitMap::count_one_bits
  • 4b4c80b: 8307351: (CmpI/L(AndI/L reg1 reg2)) on x86 can be optimized
  • d3e6d04: 8307651: RISC-V: stringL_indexof_char instruction has wrong format string
  • 2be1f10: 8307399: get rid of compatibility ThreadStart/ThreadEnd events for virtual threads
  • f5a6b7f: 8306027: Clarify JVMTI heap functions spec about virtual thread stack.
  • a1c3adb: 8307370: Add tier1 testing with thread factory in CI
  • 356667f: 8307466: java.time.Instant calculation bug in until and between methods
  • 723582c: 8306881: Update FreeType to 2.13.0
  • 9829424: 8307128: Open source some drag and drop tests 4
  • ... and 110 more: https://git.openjdk.org/jdk/compare/a8bf2acb7db63b508ef169e42a27b9c99178cbb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2023
@AlanBateman
Copy link
Contributor

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8307244 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 2, 2023
@AlanBateman
Copy link
Contributor

AlanBateman commented May 2, 2023

As I see, this transport was deprecated for some time.
But it is not clear in what release.

The JMX Remote API (javax.management.remote.rmi) was changed in Java 8 (and JSR-160 MR3) to make the IIOP transport optional (JDK-8001048). Support for the IIOP transport was removed from the JMX Remote API in Java 9 (JDK-8043937). Separately, RMI-IIOP was removed from the platform in Java 11 (JEP 320).

javax.management.remote.rmi.RMIIIOPServerImpl has been deprecated and "degraded" since Java 9. Its constructor is specified to throw UOE. As I recall, it was more of an implementation class that we couldn't remove at the time. It seems a good time now to finally remove this class.

I've added the csr label to the PR as this will need to be tracked as an API change.

@kevinjwalls
Copy link
Contributor Author

Thanks Alan - I had read JDK-8043937 as being where we remove IIOP completely as a transport for JMX (after earlier changes to not build it by default, JDK-8001048 and JDK-8033366).

I see https://bugs.openjdk.org/browse/CCC-8043937
records that we deprecated javax.management.remote.rmi.RMIIIOPServerImpl.java

I can add a CSR for removal to make this final and complete as I think was intended.

@dfuch
Copy link
Member

dfuch commented May 3, 2023

Looks good to me. I probably wouldn't have bothered with removing the example of IIOP JMXServiceURL as arguably functional implementations of that might still exist (as long as they don't extend RMIIIOPServerImpl, which is not a requirement).
The constructor of RMIIIOPServerImpl throws UnsupportedOperationException unconditionally, so there can't exist any functional subclasses of that class that could be instantiated on Java versions posterior to Java 9.
As such removing that class from the public API sounds reasonable.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing RMIIIOPServerImpl is fine, I think I agree with Daniel on leaving out the change to RMIConnector. It may use "iiop" but it just an example.

@kevinjwalls
Copy link
Contributor Author

Thanks for all the comments and reviews.
On the RMIConnector example, I had thought it was misleading to use as an example something which used to work, but which no longer works. But this change doesn't affect whether other address syntaxes are recognised.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 5, 2023
@kevinjwalls
Copy link
Contributor Author

Putting the example back in RMIConnector, but I was keen to remove "iiop" from search results here, so with a generic placeholder for the protocol.

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 9af1787.
Since your change was applied there have been 129 commits pushed to the master branch:

  • 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
  • 0198afc: 8305748: Clarify reentrant behavior of close() in FileInputStream, FileOutputStream, and RandomAccessFile
  • 1bca05e: 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause
  • cc39689: 8300245: Replace NULL with nullptr in share/jfr/
  • 4251b56: 8306843: JVMTI tag map extremely slow after JDK-8292741
  • ab34cb9: 8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java
  • 0da48f1: 8307732: build-test-lib is broken
  • 4aa65cb: 8285932: Implementation of JEP 430 String Templates (Preview)
  • da2c930: 8302845: Replace finalizer usage in JNDI DNS provider with Cleaner
  • 540c706: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection
  • ... and 119 more: https://git.openjdk.org/jdk/compare/a8bf2acb7db63b508ef169e42a27b9c99178cbb1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@kevinjwalls Pushed as commit 9af1787.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
4 participants