Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8307083: Open source some drag and drop tests 3 #13764

Closed
wants to merge 5 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented May 2, 2023

moving tests to open


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13764/head:pull/13764
$ git checkout pull/13764

Update a local copy of the PR:
$ git checkout pull/13764
$ git pull https://git.openjdk.org/jdk.git pull/13764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13764

View PR using the GUI difftool:
$ git pr show -t 13764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13764.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 3, 2023

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307083: Open source some drag and drop tests 3

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 248 new commits pushed to the master branch:

  • 6f75dd8: 8308236: Remove SystemDictionaryShared::clone_dumptime_tables()
  • 83c096d: 8308270: ARM32 build broken after JDK-8304913
  • 902585b: 8308110: Resolve multiple definition of 'JNI_OnLoad_jsound' linking error
  • 6073edf: 8307483: New micros for j.u.c.LockSupport
  • 2409448: 8307365: JvmtiStressModule hit SIGSEGV in JvmtiEventControllerPrivate::recompute_thread_enabled
  • 950c5df: 8307299: Move more DnD tests to open
  • 8bedf2e: 8308292: Problemlist vmTestbase/nsk/jvmti/AttachOnDemand/attach020/TestDescription.java
  • 6d4782b: 8307976: (fs) Files.createDirectories(dir) returns dir::toAbsolutePath instead of dir
  • f57c783: 8308239: Tighten up accessibility of nested classes in java.lang.invoke
  • 64f6681: 8308246: PPC64le build broken after JDK-8304913
  • ... and 238 more: https://git.openjdk.org/jdk/compare/b76f320e76f0fb58c598fdd7a5937f1b5bb1de15...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2023
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 5, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

⚠️ @alisenchung This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, please confirm that mach5 is green.

@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 18, 2023

Going to push as commit 1b154e4.
Since your change was applied there have been 256 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2023
@openjdk openjdk bot closed this May 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@alisenchung Pushed as commit 1b154e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants