8303669: SelectVersion indexes past the end of the argv array

[asotona]

libjli/java.c's SelectVersion method receives argc and argv but ignores argc in some circumstances an instead checks if *argv == 0 in its while loop, which results in a segmentation fault if the provided array is not NULL terminated.

This patch counts down argc in the while loops instead of looking for zero termination.

Please review.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303669: SelectVersion indexes past the end of the argv array

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13775/head:pull/13775
$ git checkout pull/13775

Update a local copy of the PR:
$ git checkout pull/13775
$ git pull https://git.openjdk.org/jdk.git pull/13775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13775

View PR using the GUI difftool:
$ git pr show -t 13775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13775.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (395cf2e7)
• 00: Full (2c46bb40)

[AlanBateman]

I think this bug report is a reminder that we need to figure out if JLI was documented at some point, it's surprising to have something outside of the JDK using it directly.

Also are you planning to add a test for this?

[asotona]

Also are you planning to add a test for this?

I've added code to exeJliLaunchTest.c (executed by JliLaunchTest) to test non null terminated arguments.

[vicente-romero-oracle]

lgtm

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303669: SelectVersion indexes past the end of the argv array

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 248 new commits pushed to the master branch:

• bb24c36: 8279993: Assert that a shared class is not loaded more than once
• 1b154e4: 8307083: Open source some drag and drop tests 3
• cc5c9b5: 8305787: Wrong debugging information printed with TraceOptoOutput
• 808dc1b: 8308350: Increase buffer size for jspawnhelper arguments
• a58e0ca: 8308347: [s390x] build broken after JDK-8304913
• bfc3ccd: 8308283: Build failure with GCC12 & GCC13
• 57b8ed1: 8308290: Add fontconfig requirement to building.md
• 3c9ec26: 8306457: Classfile API components implementations should not be exposed
• f4f5542: 8306842: Classfile API performance improvements
• 95da499: 8308285: Assert on -Xshare:dump when running with -Xlog:cds=trace
• ... and 238 more: https://git.openjdk.org/jdk/compare/e0774bed2d2fcd850f5ca6884dd7aeb45f0bdaef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

Thank you.

[asotona]

/integrate

[openjdk]

Going to push as commit fa14314.
Since your change was applied there have been 259 commits pushed to the master branch:

• 25868b9: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage
• 6765761: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey
• 97ade57: 8307609: RISC-V: Added support for Extract, Compress, Expand and other nodes for Vector API
• e520cdc: 8308277: RISC-V: Improve vectorization of Match.sqrt() on floats
• 42948c0: 8307865: Invalid is_in_any_VTMS_transition() check in post_dynamic_code_generated_while_holding_locks
• 4a6d6d5: 8308187: jdi/EventSet/resume/resume008 failed with "EventHandler> Unexpected event: ThreadStartEvent in thread resume008-thread0"
• 148df53: 8308010: X509Key and PKCS8Key allows garbage bytes at the end
• d3feedf: 8308192: Error in parsing replay file when staticfield is an array of single dimension
• 02dc95e: 8308370: Fix build failures related to the java.awt.Robot documentation
• 21aa057: 8307779: Relax the java.awt.Robot specification
• ... and 249 more: https://git.openjdk.org/jdk/compare/e0774bed2d2fcd850f5ca6884dd7aeb45f0bdaef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit fa14314.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.