8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations

[dougxc]

This PRs adds JVMCI API to reflect the fact that deferred locals are not supported on virtual threads.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13777/head:pull/13777
$ git checkout pull/13777

Update a local copy of the PR:
$ git checkout pull/13777
$ git pull https://git.openjdk.org/jdk.git pull/13777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13777

View PR using the GUI difftool:
$ git pr show -t 13777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13777.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[chumer]

any reason this is not just an UnsupportedOperationException?

[dougxc]

To be 100% sure that it's the exception thrown by the test as opposed to some interleaving code that happens to also use UnsupportedOperationException.

[mlbridge]

Webrevs

• 01: Full - Incremental (ee33378a)
• 00: Full (3f5be9fc)

[TobiHartmann]

The test should be removed from test/hotspot/jtreg/ProblemList-Virtual.txt (added by JDK-8307370).

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307125: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java hits assert(!Continuation::is_frame_in_continuation(thread(), fr())) failed: No support for deferred values in continuations

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 1451ac1: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes
• 207fbcb: 8299414: JVMTI FollowReferences should support references from VirtualThread stack
• b44fa36: 8308040: Evaluate new public types in non-public classes
• ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
• bacf652: 8297887: Update Siphash
• 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
• d10467e: 8307738: JFR: EventStream.openRepository() drops events
• 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
• 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
• d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
• ... and 29 more: https://git.openjdk.org/jdk/compare/69f508a2ac344eb61cef7be985348873b8265171...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the review Tom.

/integrate

[openjdk]

Going to push as commit 89b3c37.
Since your change was applied there have been 61 commits pushed to the master branch:

• 98acce1: 8306703: JFR: Summary views
• 534de6d: 8300491: SymbolLookup::libraryLookup accepts strings with terminators
• 48d21bd: 8286597: Implement PollerProvider on AIX
• e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters
• 90e57fd: 8308335: JFR: Remove @experimental from Virtual Threads events
• 7e2e05d: 8308098: G1: Remove redundant checks in G1ObjectCountIsAliveClosure
• 2599ada: 8308655: Narrow types of ConstantPool and ConstMethod returns
• 5a0a238: 8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
• 38367d3: 8308735: Typos in parameter names
• 4f096eb: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes
• ... and 51 more: https://git.openjdk.org/jdk/compare/69f508a2ac344eb61cef7be985348873b8265171...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 89b3c37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.