Skip to content

8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836#13793

Closed
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
tschatzl:8307421-fix-comment
Closed

8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836#13793
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
tschatzl:8307421-fix-comment

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented May 4, 2023

Hi all,

please review this trivial comment fix @kimbarrett noticed while reviewing the JDK-8306836 change after having it pushed.

Testing: local compilation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13793/head:pull/13793
$ git checkout pull/13793

Update a local copy of the PR:
$ git checkout pull/13793
$ git pull https://git.openjdk.org/jdk.git pull/13793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13793

View PR using the GUI difftool:
$ git pr show -t 13793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13793.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8307421 8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836 May 4, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 4, 2023
@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • dc4096c: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)
  • 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
  • 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
  • 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2023
@tschatzl
Copy link
Contributor Author

tschatzl commented May 5, 2023

Thanks @shipilev for your review

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2023

Going to push as commit 302bc2f.
Since your change was applied there have been 15 commits pushed to the master branch:

  • e19cf26: 8307196: Dangling pointer warning for MetadataAllocationRequest
  • 1b143ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • a44e890: 8307308: Add serviceability_ttf_virtual group to exclude jvmti tests developed for virtual threads
  • 46df171: 8304948: [vectorapi] C2 crashes when expanding VectorBox
  • 111858f: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
  • 197d0cc: 8294983: SSLEngine throws ClassCastException during handshake
  • a87262e: 8307295: Add warning to not create new ACC flags
  • 0c6529d: 8307156: native_thread not protected by TLH
  • 5ca0b08: 8307133: Open source some JTable jtreg tests
  • 2adb3b4: 8306943: Open source several dnd AWT tests
  • ... and 5 more: https://git.openjdk.org/jdk/compare/e206d57bfc09032e17d09714fc54ab2f5e961792...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2023
@openjdk openjdk bot closed this May 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@tschatzl Pushed as commit 302bc2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8307421-fix-comment branch May 5, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants