8223187: Remove setLocale() call in jpackage native launcher

[sashamatveev]

setlocale() affects several C functions. We do not use most of these functions. We only using isspace() and toLower(). Based on how we use it I do not see any needs for setlocale(). After removing it I retested jpackage by changing locally on machine and using different language as input parameters for jpackage. No issues found.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8223187: Remove setLocale() call in jpackage native launcher

Reviewers

• Kevin Rushforth (@kevinrushforth - Author)
• Andy Herrick (@andyherrick - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/138/head:pull/138
$ git checkout pull/138

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sashamatveev The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (f7e56fb)

[kevinrushforth]

Looks good. I confirmed that these are the only two calls to setlocale in the jpackage sources.

[kevinrushforth]

Note: the title of the JBS bug was updated. Can you update the PR title to match?

[andyherrick]

Looks good to me.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8223187: Remove setLocale() call in jpackage native launcher

Reviewed-by: kcr, herrick, naoto

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 44 commits pushed to the master branch:

• 9c24a56: 8253029: [PPC64] Remove obsolete Power6 code
• e6a493a: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler
• 68da63d: 8240658: Code completion not working for lambdas in method invocations that require type inference
• b05290a: 8252898: remove bulk registration of JFR CompilerPhaseType names
• 779d2c3: 8253084: Zero VM is broken after JDK-8252689
• 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds
• f978f6f: 8252689: Classes are loaded from jrt:/java.base even when CDS is used
• c5e63b6: 8248186: Move CDS C++ vtable code to cppVtables.cpp
• 03a4df0: 8244778: Archive full module graph in CDS
• 998ce78: 8252543: [JVMCI] Libgraal can deadlock in blocking compilation mode
• ... and 34 more: https://git.openjdk.java.net/jdk/compare/26c7218ab9ce4e26a25f98ee6c72da48b83be471...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 9c24a5635ee4caa81fef2f49c1f323d86ddc02c6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

Although I am curious why the setlocale() call was introduced in the first place, removing it in order to respect the platform default locale is generally considered a welcoming change. Approving the change assuming locale related testing has been done.

[sashamatveev]

/integrate

[openjdk]

@sashamatveev Since your change was applied there have been 44 commits pushed to the master branch:

• 9c24a56: 8253029: [PPC64] Remove obsolete Power6 code
• e6a493a: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler
• 68da63d: 8240658: Code completion not working for lambdas in method invocations that require type inference
• b05290a: 8252898: remove bulk registration of JFR CompilerPhaseType names
• 779d2c3: 8253084: Zero VM is broken after JDK-8252689
• 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds
• f978f6f: 8252689: Classes are loaded from jrt:/java.base even when CDS is used
• c5e63b6: 8248186: Move CDS C++ vtable code to cppVtables.cpp
• 03a4df0: 8244778: Archive full module graph in CDS
• 998ce78: 8252543: [JVMCI] Libgraal can deadlock in blocking compilation mode
• ... and 34 more: https://git.openjdk.java.net/jdk/compare/26c7218ab9ce4e26a25f98ee6c72da48b83be471...master

Your commit was automatically rebased without conflicts.

Pushed as commit ac9d1b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.