Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307448: Test RedefineSharedClassJFR fail due to wrong assumption #13801

Closed
wants to merge 2 commits into from

Conversation

kstefanj
Copy link
Contributor

@kstefanj kstefanj commented May 4, 2023

Please review this fix to avoid a tier1 test failure.

Summary
The newly added test wrongfully assumed that one of the transformed classes would be in use. This seem to be the case in most runs, but there is no guarantee. This change fixes the test to only verify that nothing is seen as shared when running with -Xshare:off.

Testing
Verified that the test still passes locally.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307448: Test RedefineSharedClassJFR fail due to wrong assumption

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13801/head:pull/13801
$ git checkout pull/13801

Update a local copy of the PR:
$ git checkout pull/13801
$ git pull https://git.openjdk.org/jdk.git pull/13801/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13801

View PR using the GUI difftool:
$ git pr show -t 13801

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13801.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@kstefanj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label May 4, 2023
@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@kstefanj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307448: Test RedefineSharedClassJFR fail due to wrong assumption

Reviewed-by: eosterlund, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2023
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly.

@kstefanj
Copy link
Contributor Author

kstefanj commented May 4, 2023

Thanks @coleenp and @fisk for the quick reviews.

Since the test failure shows up in tier 1 I will push this without waiting 24 hours.

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 29233e0.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@kstefanj Pushed as commit 29233e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants