-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307448: Test RedefineSharedClassJFR fail due to wrong assumption #13801
Conversation
👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@kstefanj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this so quickly.
Going to push as commit 29233e0. |
Please review this fix to avoid a tier1 test failure.
Summary
The newly added test wrongfully assumed that one of the transformed classes would be in use. This seem to be the case in most runs, but there is no guarantee. This change fixes the test to only verify that nothing is seen as shared when running with -Xshare:off.
Testing
Verified that the test still passes locally.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13801/head:pull/13801
$ git checkout pull/13801
Update a local copy of the PR:
$ git checkout pull/13801
$ git pull https://git.openjdk.org/jdk.git pull/13801/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13801
View PR using the GUI difftool:
$ git pr show -t 13801
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13801.diff
Webrev
Link to Webrev Comment