Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots #13804

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented May 4, 2023

Closed in favor of #13809

This PR is to make it easier to review documentation changes from #13803 and also covers the following issues~~
https://bugs.openjdk.org/browse/JDK-8280982 [Wayland] [XWayland] java.awt.Robot taking screenshots
https://bugs.openjdk.org/browse/JDK-8280995 [XWayland] Robot.mouseMove does not visually move mouse cursor
https://bugs.openjdk.org/browse/JDK-8280990 [XWayland] XTest emulated mouse click does not bring window to front.
https://bugs.openjdk.org/browse/JDK-8280988 [XWayland] Click on title to request focus test failures

Doc changes are on top of #13803


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8307456 to be approved

Issues

  • JDK-8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots
  • JDK-8307456: [Wayland] [XWayland] java.awt.Robot taking screenshots (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13804/head:pull/13804
$ git checkout pull/13804

Update a local copy of the PR:
$ git checkout pull/13804
$ git pull https://git.openjdk.org/jdk.git pull/13804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13804

View PR using the GUI difftool:
$ git pr show -t 13804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13804.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@azvegint The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels May 4, 2023
@azvegint
Copy link
Member Author

azvegint commented May 4, 2023

/label remove build

@openjdk
Copy link

openjdk bot commented May 4, 2023

⚠️ @azvegint This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review and removed build build-dev@openjdk.org labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@azvegint
The build label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

@kevinrushforth
Copy link
Member

@azvegint what is your plan for eventually integrating this? You can't integrate two separate PRs for the same bug ID, so if you want to integrate them separately, then you will need two different bug IDs; that might be best anyway, since I'm pretty sure you want the spec changes to go in separately and first. If you do intend to integrate this with as a single commit for a single bug ID, then you can make this PR as Draft and eventually fold it into the other PR.

@prrace Can you comment as to how you want to proceed?

@azvegint
Copy link
Member Author

azvegint commented May 4, 2023

@kevinrushforth

thanks for your suggestions.

I do not plan to integrate this PR, I would like to first discuss all questions regarding the documentation here, separately, and add the final version to the main PR #13803

If you do intend to integrate this with as a single commit for a single bug ID, then you can make this PR as Draft and eventually fold it into the other PR.

I created a new draft PR for this #13809.

This PR got polluted with "tab to spaces" changes, hence closing it.

@azvegint azvegint closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants