-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes #13808
Conversation
…r for incompatible processes
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
Webrevs
|
@lmesnik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7f05f6f.
Your commit was automatically rebased without conflicts. |
The ProcessTools has some support of jtreg thread factory functionality.
It tries to run the new process using virtual thread to run
main()
method.This fix updates it to skip the java runs where no main class is involved and more correctly process options which has 2nd argument.
Also is sets
main.wrapper
property to allow launched process understand id any wrappers is used.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13808/head:pull/13808
$ git checkout pull/13808
Update a local copy of the PR:
$ git checkout pull/13808
$ git pull https://git.openjdk.org/jdk.git pull/13808/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13808
View PR using the GUI difftool:
$ git pr show -t 13808
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13808.diff
Webrev
Link to Webrev Comment