Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes #13808

Closed
wants to merge 4 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented May 4, 2023

The ProcessTools has some support of jtreg thread factory functionality.
It tries to run the new process using virtual thread to run main() method.
This fix updates it to skip the java runs where no main class is involved and more correctly process options which has 2nd argument.
Also is sets main.wrapper property to allow launched process understand id any wrappers is used.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13808/head:pull/13808
$ git checkout pull/13808

Update a local copy of the PR:
$ git checkout pull/13808
$ git pull https://git.openjdk.org/jdk.git pull/13808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13808

View PR using the GUI difftool:
$ git pr show -t 13808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13808.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@lmesnik The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 4, 2023
@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307307: Improve ProcessTools.java to don't try to run Virtual wrapper for incompatible processes

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 82bcee7: 8159337: Introduce a method in Locale class to return the language tags as per RFC 5646 convention

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@lmesnik
Copy link
Member Author

lmesnik commented May 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2023

Going to push as commit 7f05f6f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dde557e: 8304148: Remapping a class with Invokedynamic constant loses static bootstrap arguments
  • 82bcee7: 8159337: Introduce a method in Locale class to return the language tags as per RFC 5646 convention

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2023
@openjdk openjdk bot closed this May 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@lmesnik Pushed as commit 7f05f6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants