8306712: CDS DeterministicDump.java test fails with -XX:+UseStringDeduplication

[calvinccheung]

Please review this change for:

• disabling UseStringDeduplication while dumping CDS archive;
• removing the unnecessary !compressed check from the test.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306712: CDS DeterministicDump.java test fails with -XX:+UseStringDeduplication

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 1f4389fd
• Matias Saavedra Silva (@matias9927 - Committer) ⚠️ Review applies to 1f4389fd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13810/head:pull/13810
$ git checkout pull/13810

Update a local copy of the PR:
$ git checkout pull/13810
$ git pull https://git.openjdk.org/jdk.git pull/13810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13810

View PR using the GUI difftool:
$ git pr show -t 13810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13810.diff

Webrev

Link to Webrev Comment

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (29c0ed47)
• 00: Full (1f4389fd)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306712: CDS DeterministicDump.java test fails with -XX:+UseStringDeduplication

Reviewed-by: iklam, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 3968ab5: 8307395: Add missing STS to Shenandoah
• 12d6ec6: 8307236: Rendezvous GC threads under STS for monitor deflation
• 6fe959c: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at
• 3f6a354: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
• f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
• 746f8d1: 8305714: Add an extra test for JDK-8292755
• 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
• 3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
• 948f3b3: 8301493: Replace NULL with nullptr in cpu/aarch64
• f94f957: 8307331: Correctly update line maps when class redefine rewrites bytecodes
• ... and 56 more: https://git.openjdk.org/jdk/compare/561ec9c5a06e5baeb0cf72463d14d1d720facb13...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Very straight forward, LGTM!
Edit: Please update the copyright on DeterministicDump.java

[calvinccheung]

Thanks @iklam and @matias9927 for the review.
/integrate

[openjdk]

Going to push as commit 65a5488.
Since your change was applied there have been 69 commits pushed to the master branch:

• d8b230c: 8307301: Update HarfBuzz to 7.2.0
• b5a4827: 8306871: Open source more AWT Drag & Drop tests
• 47422be: 8307375: Alignment check on layouts used as sequence element is not correct
• 3968ab5: 8307395: Add missing STS to Shenandoah
• 12d6ec6: 8307236: Rendezvous GC threads under STS for monitor deflation
• 6fe959c: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at
• 3f6a354: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
• f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
• 746f8d1: 8305714: Add an extra test for JDK-8292755
• 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
• ... and 59 more: https://git.openjdk.org/jdk/compare/561ec9c5a06e5baeb0cf72463d14d1d720facb13...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 65a5488.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.