Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 #13816

Closed
wants to merge 4 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 4, 2023

Trivial fixes to ProblemList a few tests:

  • JDK-8307489 ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
  • JDK-8307490 ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux-x64 and macosx-x64
  • JDK-8307491 ProblemList sanity/client/SwingSet/src/EditorPaneDemoTest.java on linux-x64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
  • JDK-8307490: ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux-x64 and macosx-x64
  • JDK-8307491: ProblemList sanity/client/SwingSet/src/EditorPaneDemoTest.java on linux-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13816/head:pull/13816
$ git checkout pull/13816

Update a local copy of the PR:
$ git checkout pull/13816
$ git pull https://git.openjdk.org/jdk.git pull/13816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13816

View PR using the GUI difftool:
$ git pr show -t 13816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13816.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label hotspot-runtime
/label core-libs
/label security-libs
/label client

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8307489
/issue JDK-8307490
/issue JDK-8307491

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
The label security-libs is not a valid label.
These labels are valid:

  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
The client label was successfully added.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8307490: ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux-x64 and macosx-x64.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8307491: ProblemList sanity/client/SwingSet/src/EditorPaneDemoTest.java on linux-x64.

@dcubed-ojdk
Copy link
Member Author

/label security

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 4, 2023 21:05
@openjdk openjdk bot added rfr Pull request is ready for review security security-dev@openjdk.org labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk
The security label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
8307490: ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux-x64 and macosx-x64
8307491: ProblemList sanity/client/SwingSet/src/EditorPaneDemoTest.java on linux-x64

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2023
@dcubed-ojdk
Copy link
Member Author

@jddarcy - Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 111858f.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@dcubed-ojdk Pushed as commit 111858f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8307489 branch May 4, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants