Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner #13829

Closed
wants to merge 1 commit into from

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented May 5, 2023

Could someone please review this PR? It is a small change to increase the time that the client waits for the server thread to start.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13829/head:pull/13829
$ git checkout pull/13829

Update a local copy of the PR:
$ git checkout pull/13829
$ git pull https://git.openjdk.org/jdk.git pull/13829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13829

View PR using the GUI difftool:
$ git pr show -t 13829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13829.diff

Webrev

Link to Webrev Comment

…va -- test server didn't start in timely manner
@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

Copy link
Member

@sisahoo sisahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for a reviewer to complete the review.

@openjdk
Copy link

openjdk bot commented May 5, 2023

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner

Reviewed-by: ssahoo, jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
  • 746f8d1: 8305714: Add an extra test for JDK-8292755
  • 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
  • 3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
  • 948f3b3: 8301493: Replace NULL with nullptr in cpu/aarch64
  • f94f957: 8307331: Correctly update line maps when class redefine rewrites bytecodes
  • 302bc2f: 8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836
  • e19cf26: 8307196: Dangling pointer warning for MetadataAllocationRequest
  • 1b143ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • a44e890: 8307308: Add serviceability_ttf_virtual group to exclude jvmti tests developed for virtual threads
  • ... and 3 more: https://git.openjdk.org/jdk/compare/a87262efb2c0f5ed1773533d69d7d2091eba1462...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sisahoo, @jnimeh) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2023
@mpdonova
Copy link
Contributor Author

mpdonova commented May 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@mpdonova
Your change (at version 6d7437e) is now ready to be sponsored by a Committer.

@jnimeh
Copy link
Member

jnimeh commented May 5, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 5, 2023

Going to push as commit 3f6a354.
Since your change was applied there have been 13 commits pushed to the master branch:

  • f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
  • 746f8d1: 8305714: Add an extra test for JDK-8292755
  • 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
  • 3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
  • 948f3b3: 8301493: Replace NULL with nullptr in cpu/aarch64
  • f94f957: 8307331: Correctly update line maps when class redefine rewrites bytecodes
  • 302bc2f: 8307421: Fix comment in g1CollectionSetChooser.hpp after JDK-8306836
  • e19cf26: 8307196: Dangling pointer warning for MetadataAllocationRequest
  • 1b143ba: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • a44e890: 8307308: Add serviceability_ttf_virtual group to exclude jvmti tests developed for virtual threads
  • ... and 3 more: https://git.openjdk.org/jdk/compare/a87262efb2c0f5ed1773533d69d7d2091eba1462...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2023
@openjdk openjdk bot closed this May 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@jnimeh @mpdonova Pushed as commit 3f6a354.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants