Skip to content

8306941: Open source several datatransfer and dnd AWT tests#13836

Closed
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_applet_dnd_datatransfer_8306941
Closed

8306941: Open source several datatransfer and dnd AWT tests#13836
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_applet_dnd_datatransfer_8306941

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented May 5, 2023

Open sourcing few more tests:

java/awt/datatransfer/MimeFormatsTest/MimeFormatsTest.java
java/awt/datatransfer/RemoveFlavorListenerTest/RemoveFlavorListenerTest.java
java/awt/dnd/AutoscrollStopTest/AutoscrollStopTest.java
java/awt/dnd/ButtonReleaseTest/ButtonReleaseTest.java 

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306941: Open source several datatransfer and dnd AWT tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13836/head:pull/13836
$ git checkout pull/13836

Update a local copy of the PR:
$ git checkout pull/13836
$ git pull https://git.openjdk.org/jdk.git pull/13836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13836

View PR using the GUI difftool:
$ git pr show -t 13836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13836.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 5, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306941: Open source several datatransfer and dnd AWT tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b5a4827: 8306871: Open source more AWT Drag & Drop tests
  • 47422be: 8307375: Alignment check on layouts used as sequence element is not correct
  • 3968ab5: 8307395: Add missing STS to Shenandoah

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2023
@azvegint
Copy link
Member Author

azvegint commented May 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2023

@azvegint An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

@azvegint
Copy link
Member Author

azvegint commented May 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2023

Going to push as commit 3d3eaed.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 1f57ce0: 8307446: RISC-V: Improve performance of floating point to integer conversion
  • 4e4828e: 8307553: Remove dead code MetaspaceClosure::push_method_entry
  • 7d58978: 8280031: Deprecate GTK2 for removal
  • b5922c3: 8305846: Support compilation in Proc test utility
  • 73ac710: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • e2b1013: 8306326: [BACKOUT] 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects
  • 4386d42: 8307381: Open Source JFrame, JIF related Swing Tests
  • 27764e6: 8306583: Add JVM crash check in CDSTestUtils.executeAndLog
  • 6c71859: 6176679: Application freezes when copying an animated gif image to the system clipboard
  • 65a5488: 8306712: CDS DeterministicDump.java test fails with -XX:+UseStringDeduplication
  • ... and 4 more: https://git.openjdk.org/jdk/compare/12d6ec66a6cc668c929b3ebefd52a0dcac34771a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2023
@openjdk openjdk bot closed this May 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2023
@openjdk
Copy link

openjdk bot commented May 6, 2023

@azvegint Pushed as commit 3d3eaed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants