JDK-8307563: make most fields final in JavacTrees

[jonathan-gibbons]

Please review a small cleanup fix to address a comment left a long time back.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307563: make most fields final in JavacTrees

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13847/head:pull/13847
$ git checkout pull/13847

Update a local copy of the PR:
$ git checkout pull/13847
$ git pull https://git.openjdk.org/jdk.git pull/13847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13847

View PR using the GUI difftool:
$ git pr show -t 13847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13847.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (19977292)

[vicente-romero-oracle]

looks good

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307563: make most fields final in `JavacTrees`

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
• cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
• edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• df90df2: 8307857: validate-source fails after JDK-8306758
• 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
• 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• 9af1787: 8307244: Remove redundant class RMIIIOPServerImpl
• 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
• 0198afc: 8305748: Clarify reentrant behavior of close() in FileInputStream, FileOutputStream, and RandomAccessFile
• 1bca05e: 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause
• ... and 60 more: https://git.openjdk.org/jdk/compare/7d58978f62bf333f256115d6592706d70144ad15...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 958d4a7.
Since your change was applied there have been 70 commits pushed to the master branch:

• f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
• cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
• edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• df90df2: 8307857: validate-source fails after JDK-8306758
• 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
• 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• 9af1787: 8307244: Remove redundant class RMIIIOPServerImpl
• 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
• 0198afc: 8305748: Clarify reentrant behavior of close() in FileInputStream, FileOutputStream, and RandomAccessFile
• 1bca05e: 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause
• ... and 60 more: https://git.openjdk.org/jdk/compare/7d58978f62bf333f256115d6592706d70144ad15...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 958d4a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.