Skip to content

8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal #13852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented May 6, 2023

Deprecate the Windows x86-32 port, with the intent to remove it in a future release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13852/head:pull/13852
$ git checkout pull/13852

Update a local copy of the PR:
$ git checkout pull/13852
$ git pull https://git.openjdk.org/jdk.git pull/13852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13852

View PR using the GUI difftool:
$ git pr show -t 13852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13852.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2023

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2023
@openjdk
Copy link

openjdk bot commented May 6, 2023

@gdams The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label May 6, 2023
@mlbridge
Copy link

mlbridge bot commented May 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 6, 2023

@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented May 8, 2023

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307573: Implementation of JEP 449: Deprecate the Windows 32-bit x86 Port for Removal

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 4f88437: 8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.
  • dc30e68: 8308407: libjvm library not reproducibly comparable between vendors
  • 18e2446: 8301381: Verify DTLS 1.0 cannot be negotiated
  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 3d550f7: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland
  • 05e99db: 7065228: To interpret case-insensitive string locale independently
  • a970519: 8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms
  • 6b65e57: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex
  • 8011ba7: 8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning
  • 8aa5028: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 8, 2023
@gdams
Copy link
Member Author

gdams commented May 19, 2023

This JEP has now been moved from "Proposed to target" to "Targeted" which means I think we can merge this now.

@dholmes-ora
Copy link
Member

@gdams please see my comment above re the wording. Thanks

@gdams
Copy link
Member Author

gdams commented May 22, 2023

@gdams please see my comment above re the wording. Thanks

@dholmes-ora updated PTAL

@gdams
Copy link
Member Author

gdams commented May 22, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@gdams
Your change (at version 29c960a) is now ready to be sponsored by a Committer.

@JesperIRL
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit 29b8d3d.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 5fc9b57: 8308276: Change layout API to work with bytes, not bits
  • 91aeb5d: 8287834: Add SymbolLookup::or method
  • 4f88437: 8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.
  • dc30e68: 8308407: libjvm library not reproducibly comparable between vendors
  • 18e2446: 8301381: Verify DTLS 1.0 cannot be negotiated
  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 3d550f7: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland
  • 05e99db: 7065228: To interpret case-insensitive string locale independently
  • a970519: 8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms
  • 6b65e57: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex
  • ... and 2 more: https://git.openjdk.org/jdk/compare/b58879790083b704da94ea1476fcadb0e65b0805...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 22, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@JesperIRL @gdams Pushed as commit 29b8d3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the jep449 branch May 22, 2023 15:55
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants