8307575: Migrate the serialization constructor accessors to Method Handles

[liach]

Apparently method handle linking doesn't impose extra checks on constructor invocation, so the special logic for the serialization constructor to call superclass constructor in MagicAccessorImpl can be removed altogether with old core reflection implementation.

Serialization and sun.reflect.ReflectionFactory tests pass. May be worth to think about the long-term treatment of ReflectionFactory.newConstructorForSerialization, as creating partial object is inherently unsafe, and behavior of newConstructorForSerialization(ArrayList.class, String.class.getDeclaredConstructor(String.class)) etc. (which is accepted for now) may have unpredictable side effects.

#1830 has a similar patch; this one doesn't touch proxies and updates to the new post-JEP 416 reflection implementation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307575: Migrate the serialization constructor accessors to Method Handles (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13853/head:pull/13853
$ git checkout pull/13853

Update a local copy of the PR:
$ git checkout pull/13853
$ git pull https://git.openjdk.org/jdk.git pull/13853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13853

View PR using the GUI difftool:
$ git pr show -t 13853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13853.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (5d560d1e)
• 01: Full - Incremental (3a0393a9)
• 00: Full (64a8f518)

[wangweij]

/label remove security

[openjdk]

@wangweij
The security label was successfully removed.

[openjdk]

@liach this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout explore/mh-serial-constructor
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.