Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 8, 2023

The AIX build is broken after JDK-8307301 which updated harfbuzz to 7.2 .
This was expected because an older AIX workaround was removed.
Bringing back the AIX workaround solves the issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13861/head:pull/13861
$ git checkout pull/13861

Update a local copy of the PR:
$ git checkout pull/13861
$ git pull https://git.openjdk.org/jdk.git pull/13861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13861

View PR using the GUI difftool:
$ git pr show -t 13861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13861.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented May 8, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307603: [AIX] Broken build after JDK-8307301

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 8, 2023
@MBaesken
Copy link
Member Author

MBaesken commented May 8, 2023

Hi Martin, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2023

Going to push as commit bb3e44d.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2023
@openjdk openjdk bot closed this May 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@MBaesken Pushed as commit bb3e44d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants